chrome/browser/resources/settings/internet_page/network_siminfo.html - Issue 2717613002: MD Settings: add a bunch of dialog (X) aria-labels

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/network_siminfo.html

Issue 2717613002: MD Settings: add a bunch of dialog (X) aria-labels (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/network_proxy.html ('k') | chrome/browser/resources/settings/languages_page/add_languages_dialog.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/network_siminfo.html

diff --git a/chrome/browser/resources/settings/internet_page/network_siminfo.html b/chrome/browser/resources/settings/internet_page/network_siminfo.html

index b6de3eea194bad5790ff686e8ff5bd84cbc34d26..70be05fb27a1cff16bd6f4ce58d0418d08f81706 100644

--- a/chrome/browser/resources/settings/internet_page/network_siminfo.html

+++ b/chrome/browser/resources/settings/internet_page/network_siminfo.html

@@ -87,7 +87,7 @@

</div>

- <dialog is="cr-dialog" id="enterPinDialog">

+ <dialog is="cr-dialog" id="enterPinDialog" close-text="$i18n{close}">

<div class="title">$i18n{networkSimEnterPinTitle}</div>

<paper-input id="enterPin" class="pin" no-label-float

@@ -107,7 +107,7 @@

</dialog>

- <dialog is="cr-dialog" id="changePinDialog">

+ <dialog is="cr-dialog" id="changePinDialog" close-text="$i18n{close}">

<div class="title">$i18n{networkSimChangePinTitle}</div>

<paper-input id="changePinOld" class="pin" no-label-float

@@ -133,7 +133,7 @@

</dialog>

- <dialog is="cr-dialog" id="unlockPinDialog">

+ <dialog is="cr-dialog" id="unlockPinDialog" close-text="$i18n{close}">

<div class="title">$i18n{networkSimLockedTitle}</div>

<paper-input id="unlockPin" class="pin" no-label-float

@@ -153,7 +153,7 @@

</dialog>

- <dialog is="cr-dialog" id="unlockPukDialog">

+ <dialog is="cr-dialog" id="unlockPukDialog" close-text="$i18n{close}">

<div class="title">$i18n{networkSimLockedTitle}</div>

<div>