Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2717423003: Revert of Add several SIMD opcodes to IA32 (Closed)

Created:
3 years, 9 months ago by Michael Achenbach
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add several SIMD opcodes to IA32 (patchset #9 id:160001 of https://codereview.chromium.org/2695613004/ ) Reason for revert: Fails with nosse4: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/13853 Original issue's description: > Add several SIMD opcodes to IA32 > > CreateInt32x4, Int32x4ExtractLane, Int32x4ReplaceLane > Int32x4Add, Int32x4Sub > > Also add paddd and psubd to ia32-assembler > > BUG= > > Review-Url: https://codereview.chromium.org/2695613004 > Cr-Commit-Position: refs/heads/master@{#43483} > Committed: https://chromium.googlesource.com/v8/v8/+/4deb9ffdecf121c69a3db7eae6698eae23a80a15 TBR=bbudge@chromium.org,gdeepti@chromium.org,bmeurer@chromium.org,jing.bao@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2717423003 Cr-Commit-Position: refs/heads/master@{#43489} Committed: https://chromium.googlesource.com/v8/v8/+/a6b20adbf946246f7001c51678d36540dd56b5db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -179 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 chunk +1 line, -8 lines 0 comments Download
M src/compiler/ia32/instruction-scheduler-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +1 line, -22 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/ia32/assembler-ia32.h View 3 chunks +0 lines, -29 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/disasm-ia32.cc View 3 chunks +0 lines, -23 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +3 lines, -2 lines 0 comments Download
D src/ia32/sse-instr.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-disasm-ia32.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of Add several SIMD opcodes to IA32
3 years, 9 months ago (2017-02-28 14:54:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717423003/1
3 years, 9 months ago (2017-02-28 14:54:18 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 14:54:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a6b20adbf946246f7001c51678d36540dd5...

Powered by Google App Engine
This is Rietveld 408576698