Issue 2716993002: [Devtools] Change logic of DataGrid's padding-left for grouping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2716993002: [Devtools] Change logic of DataGrid's padding-left for grouping (Closed)

Created:
3 years, 10 months ago by allada

Modified:
3 years, 8 months ago

Reviewers:
caseq, alph, luoe

CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Devtools] Change logic of DataGrid's padding-left for grouping If ViewportDataGrid had its nodes parent changed it was not updating the leftpadding properties to have proper indenting, this patch should fix this issue. R=alph,caseq,luoe BUG=696109

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -6 lines)			Patch
M	third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js	View	4 chunks	+14 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js	View	3 chunks	+1 line, -4 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js	View	4 chunks	+4 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/network/networkLogView.css	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2716983002 Patch 40001

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

caseq

3 years, 9 months ago (2017-03-09 01:21:07 UTC) #3

We're not supposed to change the tree structure often, so perhaps we can afford
this to be a bit more expensive in exchange for some simplicity. I wonder if we
can just call resetElement() in _detach()?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages