Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2716993002: [Devtools] Change logic of DataGrid's padding-left for grouping (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
index a584c6edda243766f2016ab2bdffedcda8f33d3f..3b89af34bba241fb07ef0623553647e61ccc6bf1 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -675,6 +675,7 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
* @protected
*/
willAttach() {
+ super.willAttach();
if (this._initiatorCell &&
SDK.NetworkLog.initiatorInfoForRequest(this._request).type === SDK.NetworkRequest.InitiatorType.Script)
this._initiatorCell.insertBefore(this._linkifiedInitiatorAnchor, this._initiatorCell.firstChild);
@@ -731,8 +732,6 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
* @param {!Element} cell
*/
_renderNameCell(cell) {
- var leftPadding = this.leftPadding ? this.leftPadding + 'px' : '';
- cell.style.setProperty('padding-left', leftPadding);
this._nameCell = cell;
cell.addEventListener('dblclick', this._openInNewTab.bind(this), false);
var iconElement;
@@ -955,8 +954,6 @@ Network.NetworkGroupNode = class extends Network.NetworkNode {
createCell(columnIdentifier) {
var cell = this.createTD(columnIdentifier);
if (columnIdentifier === 'name') {
- var leftPadding = this.leftPadding ? this.leftPadding + 'px' : '';
- cell.style.setProperty('padding-left', leftPadding);
cell.classList.add('disclosure');
this._setTextAndTitle(cell, this._displayName);
}

Powered by Google App Engine
This is Rietveld 408576698