third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js - Issue 2716993002: [Devtools] Change logic of DataGrid's padding-left for grouping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2716993002: [Devtools] Change logic of DataGrid's padding-left for grouping (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js ('k') | third_party/WebKit/Source/devtools/front_end/network/networkLogView.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

index 37d0a06fbc967884c595a6e873a1f32d18855c7f..ecb7431d5ccee0400c92967e0f586d61a99e2d7f 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

@@ -53,6 +53,7 @@ Network.NetworkLogViewColumns = class {

id: columnConfig.id,

title: columnConfig.title,

sortable: columnConfig.sortable,

+ disclosure: columnConfig.disclosure,

align: columnConfig.align,

nonSelectable: columnConfig.nonSelectable,

weight: columnConfig.weight

@@ -609,6 +610,7 @@ Network.NetworkLogViewColumns._initialSortColumn = 'waterfall';

* subtitle: (string|null),

* visible: boolean,

* weight: number,

+ * disclosure: boolean,

* hideable: boolean,

* nonSelectable: boolean,

* sortable: boolean,

@@ -635,6 +637,7 @@ Network.NetworkLogViewColumns._defaultColumnConfig = {

weight: 6,

sortable: true,

hideable: true,

+ disclosure: false,

nonSelectable: true,

isResponseHeader: false,

alwaysVisible: false,

@@ -651,6 +654,7 @@ Network.NetworkLogViewColumns._defaultColumns = [

subtitle: Common.UIString('Path'),

visible: true,

weight: 20,

+ disclosure: true,

hideable: false,

nonSelectable: false,

alwaysVisible: true,