Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Issue 2716503005: [Mac] Fix bubble origin for animated Omnibox decorations (Closed)

Created:
3 years, 10 months ago by Sidney San Martín
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix bubble origin for animated Omnibox decorations Conceptually similar to the code removed in https://codereview.chromium.org/2594543004 but now takes padding into account so that the arrow isn't offset. BUG=687079 Review-Url: https://codereview.chromium.org/2706273004 Cr-Commit-Position: refs/heads/master@{#452160} (cherry picked from commit ac719a4ad8dd599eea270444f37a3cc3a05be4a5) Review-Url: https://codereview.chromium.org/2716503005 . Cr-Commit-Position: refs/branch-heads/2987@{#664} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/eb17964584d04aecd6c3fd8217c6f0d1d4313831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Sidney San Martín
3 years, 10 months ago (2017-02-23 19:33:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eb17964584d04aecd6c3fd8217c6f0d1d4313831.

Powered by Google App Engine
This is Rietveld 408576698