Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2706273004: [Mac] Fix bubble origin for animated Omnibox decorations (Closed)

Created:
3 years, 10 months ago by lgrey
Modified:
3 years, 10 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix bubble origin for animated Omnibox decorations Conceptually similar to the code removed in https://codereview.chromium.org/2594543004 but now takes padding into account so that the arrow isn't offset. BUG=687079 Review-Url: https://codereview.chromium.org/2706273004 Cr-Commit-Position: refs/heads/master@{#452160} Committed: https://chromium.googlesource.com/chromium/src/+/ac719a4ad8dd599eea270444f37a3cc3a05be4a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
lgrey
PTAL :)
3 years, 10 months ago (2017-02-21 22:14:17 UTC) #2
Sidney San Martín
LGTM. Is the bubble supposed to be in a different vertical position for different decorations? ...
3 years, 10 months ago (2017-02-22 14:58:44 UTC) #3
lgrey
On 2017/02/22 14:58:44, sdy wrote: > LGTM. Is the bubble supposed to be in a ...
3 years, 10 months ago (2017-02-22 15:30:03 UTC) #4
lgrey
Thanks, Sidney! Mark PTAL for OWNERS :)
3 years, 10 months ago (2017-02-22 15:30:53 UTC) #6
Sidney San Martín
On 2017/02/22 15:30:03, lgrey wrote: > On 2017/02/22 14:58:44, sdy wrote: > > LGTM. Is ...
3 years, 10 months ago (2017-02-22 15:46:59 UTC) #7
Mark Mentovai
LGTM
3 years, 10 months ago (2017-02-22 18:40:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706273004/1
3 years, 10 months ago (2017-02-22 18:41:31 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 19:17:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac719a4ad8dd599eea270444f37a...

Powered by Google App Engine
This is Rietveld 408576698