[Mac] Fix bubble origin for animated Omnibox decorations

[Mac] Fix bubble origin for animated Omnibox decorations

Conceptually similar to the code removed in https://codereview.chromium.org/2594543004
but now takes padding into account so that the arrow isn't offset.

BUG=687079
Review-Url: https://codereview.chromium.org/2706273004
Cr-Commit-Position: refs/heads/master@{#452160}
Committed: https://chromium.googlesource.com/chromium/src/+/ac719a4ad8dd599eea270444f37a3cc3a05be4a5

[lgrey, 2017-02-21 22:14:16]

lgrey@chromium.org changed reviewers:
+ sdy@chromium.org

[lgrey, 2017-02-21 22:14:17]

PTAL :)

[Sidney San Martín, 2017-02-22 14:58:44]

LGTM. Is the bubble supposed to be in a different vertical position for
different decorations? That seems to be the case in stable, so not related to
this CL, just curious.

[lgrey, 2017-02-22 15:30:03]

On 2017/02/22 14:58:44, sdy wrote:
> LGTM. Is the bubble supposed to be in a different vertical position for
> different decorations? That seems to be the case in stable, so not related to
> this CL, just curious.

It uses the bottom of the actual image, with a fixed offset, so I could see it
being higher for a smaller image etc. As far as I can recall, I didn't change
the vertical logic from what was there before.

[lgrey, 2017-02-22 15:30:53]

lgrey@chromium.org changed reviewers:
+ mark@chromium.org

[lgrey, 2017-02-22 15:30:53]

Thanks, Sidney!

Mark PTAL for OWNERS :)

[Sidney San Martín, 2017-02-22 15:46:59]

On 2017/02/22 15:30:03, lgrey wrote:
> On 2017/02/22 14:58:44, sdy wrote:
> > LGTM. Is the bubble supposed to be in a different vertical position for
> > different decorations? That seems to be the case in stable, so not related
to
> > this CL, just curious.
> 
> It uses the bottom of the actual image, with a fixed offset, so I could see it
> being higher for a smaller image etc. As far as I can recall, I didn't change
> the vertical logic from what was there before.

Yeah, it doesn't look like this changed, I was just curious if you knew why it's
this way.

[Mark Mentovai, 2017-02-22 18:40:24]

LGTM

[lgrey, 2017-02-22 18:40:49]

The CQ bit was checked by lgrey@chromium.org

[commit-bot: I haz the power, 2017-02-22 18:41:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 19:17:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487788849923400, "parent_rev":
"f6abba5e558aed73885e07c3ac1abdc4595ec764", "commit_rev":
"ac719a4ad8dd599eea270444f37a3cc3a05be4a5"}

[commit-bot: I haz the power, 2017-02-22 19:17:47]

Description was changed from

==========
[Mac] Fix bubble origin for animated Omnibox decorations

Conceptually similar to the code removed in
https://codereview.chromium.org/2594543004
but now takes padding into account so that the arrow isn't offset.

BUG=687079
==========

to

==========
[Mac] Fix bubble origin for animated Omnibox decorations

Conceptually similar to the code removed in
https://codereview.chromium.org/2594543004
but now takes padding into account so that the arrow isn't offset.

BUG=687079

Review-Url: https://codereview.chromium.org/2706273004
Cr-Commit-Position: refs/heads/master@{#452160}
Committed:
https://chromium.googlesource.com/chromium/src/+/ac719a4ad8dd599eea270444f37a...
==========

[commit-bot: I haz the power, 2017-02-22 19:17:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac719a4ad8dd599eea270444f37a...