Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2594543004: [Mac] Fix bubble anchors in RTL (Closed)

Created:
4 years ago by lgrey
Modified:
4 years ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix bubble anchors in RTL Previously, Bubble decoration and subclasses used slightly different code to calculate where the image *should* be drawn, and where it was drawn in practice. This change unites that code and removes code that compensated for the difference. The change in ContentSettingsBubble isn't RTL specific and fixes a general regression (content settings bubbles in Canary are anchored too far to the right.) BUG=648557 Committed: https://crrev.com/fdc6c66162e754b82e2d7f5db09767733d49005c Cr-Commit-Position: refs/heads/master@{#440206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -38 lines) Patch
M chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm View 2 chunks +7 lines, -13 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm View 4 chunks +3 lines, -18 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
lgrey
PTAL :)
4 years ago (2016-12-20 18:21:37 UTC) #6
Sidney San Martín
lgtm!
4 years ago (2016-12-21 19:32:26 UTC) #7
lgrey
Thanks! Nico, PTAL for OWNERS :)
4 years ago (2016-12-21 19:36:03 UTC) #9
Nico
stampy lgtm
4 years ago (2016-12-21 19:55:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594543004/1
4 years ago (2016-12-21 20:25:40 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 20:56:47 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-21 20:59:35 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdc6c66162e754b82e2d7f5db09767733d49005c
Cr-Commit-Position: refs/heads/master@{#440206}

Powered by Google App Engine
This is Rietveld 408576698