Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2716223002: ash: Use floating point precision for laser pointer. (Closed)

Created:
3 years, 9 months ago by reveman
Modified:
3 years, 9 months ago
Reviewers:
sammiequon, Daniel Erat
CC:
chromium-reviews, kalyank, sadrul, oshima
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Use floating point precision for laser pointer. This allows for smoother movement, which is more noticable after turning on low-latency updates. BUG=696385 Review-Url: https://codereview.chromium.org/2716223002 Cr-Commit-Position: refs/heads/master@{#454975} Committed: https://chromium.googlesource.com/chromium/src/+/2eabcd9262347c01e1c5d8366891a8435420276d

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase and fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -24 lines) Patch
M ash/laser/laser_pointer_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/laser/laser_pointer_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/laser/laser_pointer_points.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/laser/laser_pointer_points.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M ash/laser/laser_pointer_points_unittest.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M ash/laser/laser_pointer_view.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/laser/laser_pointer_view.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (11 generated)
reveman
3 years, 9 months ago (2017-02-27 03:25:57 UTC) #2
sammiequon
lgtm
3 years, 9 months ago (2017-02-27 17:56:10 UTC) #3
reveman
+oshima for ash/ owner review
3 years, 9 months ago (2017-03-02 14:31:38 UTC) #5
reveman
ping for owner review
3 years, 9 months ago (2017-03-06 19:57:12 UTC) #10
reveman
-oshima +derat for ash/ owner review
3 years, 9 months ago (2017-03-06 20:50:45 UTC) #12
Daniel Erat
lgtm
3 years, 9 months ago (2017-03-06 21:22:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716223002/60001
3 years, 9 months ago (2017-03-06 21:43:20 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 22:19:35 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2eabcd9262347c01e1c5d8366891...

Powered by Google App Engine
This is Rietveld 408576698