ash: Avoid unnecessary laser pointer updates.

ash: Avoid unnecessary laser pointer updates.

Increase kAddStationaryPointsDelayMs to 16ms as updating this
more frequently is not going to make a difference on a 60FPS
display.

Also reset stationary timer each time we receive an input event
to avoid unnecessary updates.

BUG=696385
Review-Url: https://codereview.chromium.org/2723653003
Cr-Commit-Position: refs/heads/master@{#454990}
Committed: https://chromium.googlesource.com/chromium/src/+/41364502a9780a5be401e6645c527904313834fb

[reveman, 2017-02-28 02:00:16]

reveman@chromium.org changed reviewers:
+ sammiequon@chromium.org

[sammiequon, 2017-02-28 02:48:13]

Thanks! lgtm

[jdufault, 2017-02-28 20:25:08]

jdufault@chromium.org changed reviewers:
+ jdufault@chromium.org

[jdufault, 2017-02-28 20:25:08]

https://codereview.chromium.org/2723653003/diff/1/ash/laser/laser_pointer_con...
File ash/laser/laser_pointer_controller.cc (right):

https://codereview.chromium.org/2723653003/diff/1/ash/laser/laser_pointer_con...
ash/laser/laser_pointer_controller.cc:23: const int kAddStationaryPointsDelayMs
= 16;
Please document why 16ms is the minimum.

[reveman, 2017-03-02 14:42:39]

reveman@chromium.org changed reviewers:
+ oshima@chromium.org

[reveman, 2017-03-02 14:42:40]

+oshima for ash/ owner review

https://codereview.chromium.org/2723653003/diff/1/ash/laser/laser_pointer_con...
File ash/laser/laser_pointer_controller.cc (right):

https://codereview.chromium.org/2723653003/diff/1/ash/laser/laser_pointer_con...
ash/laser/laser_pointer_controller.cc:23: const int kAddStationaryPointsDelayMs
= 16;
On 2017/02/28 at 20:25:08, jdufault wrote:
> Please document why 16ms is the minimum.

Done. Also added a TODO about using the real VSYNC interval instead of a
hardcoded value.

[reveman, 2017-03-06 19:57:50]

ping for owner review

[jdufault, 2017-03-06 20:08:05]

Thanks; lgtm.

On 2017/03/06 19:57:50, reveman wrote:
> ping for owner review

oshima@ is OOO for the rest of the week, you may want to find someone else.

[reveman, 2017-03-06 20:50:12]

reveman@chromium.org changed reviewers:
+ derat@chromium.org
- oshima@chromium.org

[reveman, 2017-03-06 20:50:12]

-oshima
+derat for ash/ owner review

[Daniel Erat, 2017-03-06 21:23:24]

lgtm

[reveman, 2017-03-06 22:28:20]

The CQ bit was checked by reveman@chromium.org

[reveman, 2017-03-06 22:28:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
sammiequon@chromium.org
Link to the patchset: https://codereview.chromium.org/2723653003/#ps20001
(title: "comment and TODO")

[commit-bot: I haz the power, 2017-03-06 22:28:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 23:02:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488839300479880,
"parent_rev": "692db28a688889a7946b04debfd890673ae2269f", "commit_rev":
"41364502a9780a5be401e6645c527904313834fb"}

[commit-bot: I haz the power, 2017-03-06 23:04:39]

Description was changed from

==========
ash: Avoid unnecessary laser pointer updates.

Increase kAddStationaryPointsDelayMs to 16ms as updating this
more frequently is not going to make a difference on a 60FPS
display.

Also reset stationary timer each time we receive an input event
to avoid unnecessary updates.

BUG=696385
==========

to

==========
ash: Avoid unnecessary laser pointer updates.

Increase kAddStationaryPointsDelayMs to 16ms as updating this
more frequently is not going to make a difference on a 60FPS
display.

Also reset stationary timer each time we receive an input event
to avoid unnecessary updates.

BUG=696385

Review-Url: https://codereview.chromium.org/2723653003
Cr-Commit-Position: refs/heads/master@{#454990}
Committed:
https://chromium.googlesource.com/chromium/src/+/41364502a9780a5be401e6645c52...
==========

[commit-bot: I haz the power, 2017-03-06 23:04:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/41364502a9780a5be401e6645c52...