third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp - Issue 2716203002: blink: Fix cc/paint skia type mismatches

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp

Issue 2716203002: blink: Fix cc/paint skia type mismatches (Closed)

Patch Set: Fix canvas Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/FilterEffectBuilder.h ('K') | « third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp

index 7757374ed10b90b33b3d2b330c78435d205320e4..345a5c4c3c24d1804089a4549d8ff47b012f53bc 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp

@@ -127,8 +127,7 @@ sk_sp<SkImageFilter> buildBoxReflectFilter(const BoxReflection& reflection,

kMaxMaskBufferSize) {

bitmap.allocPixels(

SkImageInfo::MakeN32Premul(cullRect.width(), cullRect.height()));

- SkCanvas skiaCanvas(bitmap);

- PaintCanvasPassThrough canvas(&skiaCanvas);

+ PaintCanvas canvas(bitmap);

canvas.clear(SK_ColorTRANSPARENT);

canvas.translate(-cullRect.x(), -cullRect.y());

canvas.drawPicture(maskRecord);