Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

Issue 2716203002: blink: Fix cc/paint skia type mismatches (Closed)
Patch Set: Fix canvas Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the 11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution. 12 * documentation and/or other materials provided with the distribution.
13 * 13 *
14 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY 14 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
16 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 16 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
17 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY 17 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
18 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES 18 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
19 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 19 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
20 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 20 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
21 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "platform/graphics/DeferredImageDecoder.h" 26 #include "platform/graphics/DeferredImageDecoder.h"
27 27
28 #include <memory>
28 #include "platform/CrossThreadFunctional.h" 29 #include "platform/CrossThreadFunctional.h"
29 #include "platform/SharedBuffer.h" 30 #include "platform/SharedBuffer.h"
30 #include "platform/WebTaskRunner.h" 31 #include "platform/WebTaskRunner.h"
31 #include "platform/graphics/ImageDecodingStore.h" 32 #include "platform/graphics/ImageDecodingStore.h"
32 #include "platform/graphics/ImageFrameGenerator.h" 33 #include "platform/graphics/ImageFrameGenerator.h"
33 #include "platform/graphics/paint/PaintCanvas.h" 34 #include "platform/graphics/paint/PaintCanvas.h"
34 #include "platform/graphics/paint/PaintRecord.h" 35 #include "platform/graphics/paint/PaintRecord.h"
35 #include "platform/graphics/paint/PaintRecorder.h" 36 #include "platform/graphics/paint/PaintRecorder.h"
37 #include "platform/graphics/paint/PaintSurface.h"
36 #include "platform/graphics/test/MockImageDecoder.h" 38 #include "platform/graphics/test/MockImageDecoder.h"
37 #include "public/platform/Platform.h" 39 #include "public/platform/Platform.h"
38 #include "public/platform/WebThread.h" 40 #include "public/platform/WebThread.h"
39 #include "public/platform/WebTraceLocation.h" 41 #include "public/platform/WebTraceLocation.h"
40 #include "testing/gtest/include/gtest/gtest.h" 42 #include "testing/gtest/include/gtest/gtest.h"
41 #include "third_party/skia/include/core/SkImage.h" 43 #include "third_party/skia/include/core/SkImage.h"
42 #include "third_party/skia/include/core/SkPixmap.h" 44 #include "third_party/skia/include/core/SkPixmap.h"
43 #include "third_party/skia/include/core/SkSurface.h" 45 #include "third_party/skia/include/core/SkSurface.h"
44 #include "wtf/PassRefPtr.h" 46 #include "wtf/PassRefPtr.h"
45 #include "wtf/PtrUtil.h" 47 #include "wtf/PtrUtil.h"
46 #include "wtf/RefPtr.h" 48 #include "wtf/RefPtr.h"
47 #include <memory>
48 49
49 namespace blink { 50 namespace blink {
50 51
51 namespace { 52 namespace {
52 53
53 // Raw data for a PNG file with 1x1 white pixels. 54 // Raw data for a PNG file with 1x1 white pixels.
54 const unsigned char whitePNG[] = { 55 const unsigned char whitePNG[] = {
55 0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a, 0x00, 0x00, 0x00, 0x0d, 56 0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a, 0x00, 0x00, 0x00, 0x0d,
56 0x49, 0x48, 0x44, 0x52, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x01, 57 0x49, 0x48, 0x44, 0x52, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x01,
57 0x08, 0x02, 0x00, 0x00, 0x00, 0x90, 0x77, 0x53, 0xde, 0x00, 0x00, 0x00, 58 0x08, 0x02, 0x00, 0x00, 0x00, 0x90, 0x77, 0x53, 0xde, 0x00, 0x00, 0x00,
(...skipping 30 matching lines...) Expand all
88 public MockImageDecoderClient { 89 public MockImageDecoderClient {
89 public: 90 public:
90 void SetUp() override { 91 void SetUp() override {
91 ImageDecodingStore::instance().setCacheLimitInBytes(1024 * 1024); 92 ImageDecodingStore::instance().setCacheLimitInBytes(1024 * 1024);
92 m_data = SharedBuffer::create(whitePNG, sizeof(whitePNG)); 93 m_data = SharedBuffer::create(whitePNG, sizeof(whitePNG));
93 m_frameCount = 1; 94 m_frameCount = 1;
94 std::unique_ptr<MockImageDecoder> decoder = MockImageDecoder::create(this); 95 std::unique_ptr<MockImageDecoder> decoder = MockImageDecoder::create(this);
95 m_actualDecoder = decoder.get(); 96 m_actualDecoder = decoder.get();
96 m_actualDecoder->setSize(1, 1); 97 m_actualDecoder->setSize(1, 1);
97 m_lazyDecoder = DeferredImageDecoder::createForTesting(std::move(decoder)); 98 m_lazyDecoder = DeferredImageDecoder::createForTesting(std::move(decoder));
98 m_surface = SkSurface::MakeRasterN32Premul(100, 100); 99 m_surface = PaintSurface::MakeRasterN32Premul(100, 100);
99 ASSERT_TRUE(m_surface.get()); 100 ASSERT_TRUE(m_surface.get());
100 m_decodeRequestCount = 0; 101 m_decodeRequestCount = 0;
101 m_repetitionCount = cAnimationNone; 102 m_repetitionCount = cAnimationNone;
102 m_status = ImageFrame::FrameComplete; 103 m_status = ImageFrame::FrameComplete;
103 m_frameDuration = 0; 104 m_frameDuration = 0;
104 m_decodedSize = m_actualDecoder->size(); 105 m_decodedSize = m_actualDecoder->size();
105 } 106 }
106 107
107 void TearDown() override { ImageDecodingStore::instance().clear(); } 108 void TearDown() override { ImageDecodingStore::instance().clear(); }
108 109
(...skipping 13 matching lines...) Expand all
122 123
123 protected: 124 protected:
124 void useMockImageDecoderFactory() { 125 void useMockImageDecoderFactory() {
125 m_lazyDecoder->frameGenerator()->setImageDecoderFactory( 126 m_lazyDecoder->frameGenerator()->setImageDecoderFactory(
126 MockImageDecoderFactory::create(this, m_decodedSize)); 127 MockImageDecoderFactory::create(this, m_decodedSize));
127 } 128 }
128 129
129 // Don't own this but saves the pointer to query states. 130 // Don't own this but saves the pointer to query states.
130 MockImageDecoder* m_actualDecoder; 131 MockImageDecoder* m_actualDecoder;
131 std::unique_ptr<DeferredImageDecoder> m_lazyDecoder; 132 std::unique_ptr<DeferredImageDecoder> m_lazyDecoder;
132 sk_sp<SkSurface> m_surface; 133 sk_sp<PaintSurface> m_surface;
133 int m_decodeRequestCount; 134 int m_decodeRequestCount;
134 RefPtr<SharedBuffer> m_data; 135 RefPtr<SharedBuffer> m_data;
135 size_t m_frameCount; 136 size_t m_frameCount;
136 int m_repetitionCount; 137 int m_repetitionCount;
137 ImageFrame::Status m_status; 138 ImageFrame::Status m_status;
138 float m_frameDuration; 139 float m_frameDuration;
139 IntSize m_decodedSize; 140 IntSize m_decodedSize;
140 }; 141 };
141 142
142 TEST_F(DeferredImageDecoderTest, drawIntoPaintRecord) { 143 TEST_F(DeferredImageDecoderTest, drawIntoPaintRecord) {
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 SharedBuffer::create(m_data->data(), m_data->size()); 376 SharedBuffer::create(m_data->data(), m_data->size());
376 EXPECT_EQ(originalData->size(), m_data->size()); 377 EXPECT_EQ(originalData->size(), m_data->size());
377 m_lazyDecoder->setData(originalData, false); 378 m_lazyDecoder->setData(originalData, false);
378 RefPtr<SharedBuffer> newData = m_lazyDecoder->data(); 379 RefPtr<SharedBuffer> newData = m_lazyDecoder->data();
379 EXPECT_EQ(originalData->size(), newData->size()); 380 EXPECT_EQ(originalData->size(), newData->size());
380 EXPECT_EQ( 381 EXPECT_EQ(
381 0, std::memcmp(originalData->data(), newData->data(), newData->size())); 382 0, std::memcmp(originalData->data(), newData->data(), newData->size()));
382 } 383 }
383 384
384 } // namespace blink 385 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698