Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2716083002: Change directory owner listing to list joint owners together. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change directory owner listing to list joint owners together. Before this CL, directory owners are listed in import CL descriptions, but joint owners of directories are split up, e.g.: domenic@chromium.org: external/wpt/streams foolip@chromium.org: external/wpt/webvtt maksim.sisov@intel.com: external/wpt/webvtt nhiroki@chromium.org: external/wpt/workers ricea@chromium.org: external/wpt/streams This CL would make it so joint owners are listed together, e.g.: domenic@chromium.org, ricea@chromium.org: external/wpt/streams foolip@chromium.org, maksim.sisov@intel.com: external/wpt/webvtt nhiroki@chromium.org: external/wpt/workers BUG=684026 Review-Url: https://codereview.chromium.org/2716083002 Cr-Commit-Position: refs/heads/master@{#453017} Committed: https://chromium.googlesource.com/chromium/src/+/4f0dd06e26f1813daf5b99191d437995e082f20b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor.py View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 3 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
qyearsley
3 years, 10 months ago (2017-02-24 22:33:59 UTC) #2
tkent
lgtm
3 years, 10 months ago (2017-02-24 22:58:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716083002/1
3 years, 10 months ago (2017-02-24 23:16:19 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 00:31:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f0dd06e26f1813daf5b99191d43...

Powered by Google App Engine
This is Rietveld 408576698