Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

Issue 2716083002: Change directory owner listing to list joint owners together. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
index fc838c4d46b37015df804347ced362b08e6d9857..d6fbcd8a252d5a04b45a310ddfd0ee0c39c67963 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
@@ -116,18 +116,18 @@ class TestImporterTest(LoggingTestCase):
host.executive = MockExecutive(output='Last commit message\n\n')
importer = TestImporter(host)
description = importer._cl_description(directory_owners={
- 'someone@chromium.org': ['external/wpt/foo', 'external/wpt/bar'],
- 'someone-else@chromium.org': ['external/wpt/baz'],
+ ('someone@chromium.org',): ['external/wpt/foo', 'external/wpt/bar'],
+ ('x@chromium.org', 'y@chromium.org'): ['external/wpt/baz'],
})
self.assertEqual(
description,
('Last commit message\n\n'
'Directory owners for changes in this CL:\n'
- 'someone-else@chromium.org:\n'
- ' external/wpt/baz\n'
'someone@chromium.org:\n'
' external/wpt/foo\n'
- ' external/wpt/bar\n\n'
+ ' external/wpt/bar\n'
+ 'x@chromium.org, y@chromium.org:\n'
+ ' external/wpt/baz\n\n'
'TBR=qyearsley@chromium.org\n'
'NOEXPORT=true'))
@@ -173,7 +173,7 @@ class TestImporterTest(LoggingTestCase):
git.changed_files = lambda: ['third_party/WebKit/LayoutTests/external/wpt/foo/x.html']
host.git = lambda: git
importer = TestImporter(host)
- self.assertEqual(importer.get_directory_owners(), {'someone@chromium.org': ['external/wpt/foo']})
+ self.assertEqual(importer.get_directory_owners(), {('someone@chromium.org',): ['external/wpt/foo']})
def test_get_directory_owners_no_changed_files(self):
host = MockHost()
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698