Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1273)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py

Issue 2716083002: Change directory owner listing to list joint owners together. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
index 436aa2d6047b21db30704b4064ee18554b0d6d2b..4bb5a936abe567eb24f27512b992e0af0f0131ed 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
@@ -377,7 +377,7 @@ class TestImporter(object):
] + ['--cc=' + email_address for email_address in directory_owners])
def get_directory_owners(self):
- """Returns a list of email addresses of owners of changed tests."""
+ """Returns a mapping of email addresses to owners of changed tests."""
_log.info('Gathering directory owners emails to CC.')
changed_files = self.host.git().changed_files()
extractor = DirectoryOwnersExtractor(self.fs)
@@ -385,6 +385,11 @@ class TestImporter(object):
return extractor.list_owners(changed_files)
def _cl_description(self, directory_owners):
+ """Returns a CL description string.
+
+ Args:
+ directory_owners: A dict of tuples of owner names to lists of directories.
+ """
description = self.check_run(['git', 'log', '-1', '--format=%B'])
build_link = current_build_link(self.host)
if build_link:
@@ -403,9 +408,9 @@ class TestImporter(object):
@staticmethod
def _format_directory_owners(directory_owners):
message_lines = ['Directory owners for changes in this CL:']
- for owner, directories in sorted(directory_owners.items()):
- message_lines.append(owner + ':')
- message_lines.extend([' ' + d for d in directories])
+ for owner_tuple, directories in sorted(directory_owners.items()):
+ message_lines.append(', '.join(owner_tuple) + ':')
+ message_lines.extend(' ' + d for d in directories)
return '\n'.join(message_lines)
def fetch_new_expectations_and_baselines(self):

Powered by Google App Engine
This is Rietveld 408576698