[Payments] Make phone number optional for billing addresses.

[Payments] Make phone number optional for billing addresses.

Makes the phone number optional for already existing billing
addresses. When editing or adding a new address, the phone
number is still mandatory.

BUG=694598
Review-Url: https://codereview.chromium.org/2715783004
Cr-Commit-Position: refs/heads/master@{#453385}
Committed: https://chromium.googlesource.com/chromium/src/+/fa14f647f440cd6b669d3d6fab4792d12ec0a034

[sebsg, 2017-02-26 21:43:33]

Description was changed from

==========
WIP

BUG=
==========

to

==========
Makes the phone number optional for already existing billing addresses. When
editing or adding a new address, the phone number is still mandatory.

BUG=694598
==========

[sebsg, 2017-02-27 15:41:47]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 15:41:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2017-02-27 15:42:01]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-02-27 16:04:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 16:04:08]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[sebsg, 2017-02-27 17:37:48]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[sebsg, 2017-02-27 17:38:05]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-02-27 17:38:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2017-02-27 17:45:00]

sebsg@chromium.org changed reviewers:
+ rouslan@chromium.org

[sebsg, 2017-02-27 17:45:01]

Hi Rouslan, PTAL?

[please use gerrit instead, 2017-02-27 17:48:41]

Description was changed from

==========
Makes the phone number optional for already existing billing addresses. When
editing or adding a new address, the phone number is still mandatory.

BUG=694598
==========

to

==========
[Payments] Make phone number optional for billing addresses.

Makes the phone number optional for already existing billing
addresses. When editing or adding a new address, the phone
number is still mandatory.

BUG=694598
==========

[please use gerrit instead, 2017-02-27 17:58:02]

LGTM % nits

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
(right):

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java:93:
mBillingAddress, AutofillAddress.IGNORE_PHONE_COMPLETENESS_CHECK)
Define a "@CompletionCheckType private static final int
mBillingAddressCompletionCheckType =
AutofillAddress.IGNORE_PHONE_COMPLETENESS_CHECK" on top of
AutofillPaymentInstrument.java and re-use it throughout the file. That makes
future changes to this parameter easier to make.

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
(right):

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:187:
profile, AutofillAddress.IGNORE_PHONE_COMPLETENESS_CHECK));
Ditto.

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
(right):

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:433:
* @throws InterruptedException
We don't document @throws usually.

[sebsg, 2017-02-27 18:39:50]

Thanks for the comments, sending to CQ.

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
(right):

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java:93:
mBillingAddress, AutofillAddress.IGNORE_PHONE_COMPLETENESS_CHECK)
On 2017/02/27 17:58:02, rouslan wrote:
> Define a "@CompletionCheckType private static final int
> mBillingAddressCompletionCheckType =
> AutofillAddress.IGNORE_PHONE_COMPLETENESS_CHECK" on top of
> AutofillPaymentInstrument.java and re-use it throughout the file. That makes
> future changes to this parameter easier to make.

Done.

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
(right):

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:187:
profile, AutofillAddress.IGNORE_PHONE_COMPLETENESS_CHECK));
On 2017/02/27 17:58:02, rouslan wrote:
> Ditto.

Done.

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
(right):

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:433:
* @throws InterruptedException
On 2017/02/27 17:58:02, rouslan wrote:
> We don't document @throws usually.

Done.

[sebsg, 2017-02-27 18:39:51]

Thanks for the comments, sending to CQ.

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
(right):

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java:93:
mBillingAddress, AutofillAddress.IGNORE_PHONE_COMPLETENESS_CHECK)
On 2017/02/27 17:58:02, rouslan wrote:
> Define a "@CompletionCheckType private static final int
> mBillingAddressCompletionCheckType =
> AutofillAddress.IGNORE_PHONE_COMPLETENESS_CHECK" on top of
> AutofillPaymentInstrument.java and re-use it throughout the file. That makes
> future changes to this parameter easier to make.

Done.

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
(right):

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:187:
profile, AutofillAddress.IGNORE_PHONE_COMPLETENESS_CHECK));
On 2017/02/27 17:58:02, rouslan wrote:
> Ditto.

Done.

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
(right):

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:433:
* @throws InterruptedException
On 2017/02/27 17:58:02, rouslan wrote:
> We don't document @throws usually.

Done.

[sebsg, 2017-02-27 18:39:55]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2017-02-27 18:39:56]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2715783004/#ps60001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-02-27 18:40:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 19:09:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 19:09:18]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sebsg, 2017-02-27 21:53:07]

Patchset #2 (id:60001) has been deleted

[sebsg, 2017-02-27 21:54:03]

Sending to CQ

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
(right):

https://codereview.chromium.org/2715783004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java:93:
mBillingAddress, AutofillAddress.IGNORE_PHONE_COMPLETENESS_CHECK)
On 2017/02/27 18:39:50, sebsg wrote:
> On 2017/02/27 17:58:02, rouslan wrote:
> > Define a "@CompletionCheckType private static final int
> > mBillingAddressCompletionCheckType =
> > AutofillAddress.IGNORE_PHONE_COMPLETENESS_CHECK" on top of
> > AutofillPaymentInstrument.java and re-use it throughout the file. That makes
> > future changes to this parameter easier to make.
> 
> Done.

Turns out Lint doesn't like this at all :(

[sebsg, 2017-02-27 21:54:08]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2017-02-27 21:54:08]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2715783004/#ps80001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-02-27 21:55:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 23:24:12]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488232448181410,
"parent_rev": "f4e5b5bce2407d2bbe3f09fa0781162dfe6b6bc8", "commit_rev":
"fa14f647f440cd6b669d3d6fab4792d12ec0a034"}

[commit-bot: I haz the power, 2017-02-27 23:24:53]

Description was changed from

==========
[Payments] Make phone number optional for billing addresses.

Makes the phone number optional for already existing billing
addresses. When editing or adding a new address, the phone
number is still mandatory.

BUG=694598
==========

to

==========
[Payments] Make phone number optional for billing addresses.

Makes the phone number optional for already existing billing
addresses. When editing or adding a new address, the phone
number is still mandatory.

BUG=694598

Review-Url: https://codereview.chromium.org/2715783004
Cr-Commit-Position: refs/heads/master@{#453385}
Committed:
https://chromium.googlesource.com/chromium/src/+/fa14f647f440cd6b669d3d6fab47...
==========

[commit-bot: I haz the power, 2017-02-27 23:24:55]

Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/fa14f647f440cd6b669d3d6fab47...