chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java - Issue 2715783004: [Payments] Make phone number optional for billing addresses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java

Issue 2715783004: [Payments] Make phone number optional for billing addresses. (Closed)

Patch Set: Addressed comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java

index 4413a88e937345a60eefe6bdef205bb0cf2b574c..25af92dc548ad57efb3ddfa3c7d687e515a31f8a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java

@@ -183,7 +183,8 @@ public class CardEditor extends EditorBase<AutofillPaymentInstrument>

if (TextUtils.isEmpty(profile.getStreetAddress())) continue;

mProfilesForBillingAddress.add(profile);

Pair<Integer, Integer> editMessageResIds = AutofillAddress.getEditMessageAndTitleResIds(

- AutofillAddress.checkAddressCompletionStatus(profile));

+ AutofillAddress.checkAddressCompletionStatus(

+ profile, AutofillAddress.IGNORE_PHONE_COMPLETENESS_CHECK));

if (editMessageResIds.first.intValue() != 0) {

mIncompleteProfilesForBillingAddress.put(

profile.getGUID(), editMessageResIds.first);

@@ -194,10 +195,12 @@ public class CardEditor extends EditorBase<AutofillPaymentInstrument>

Collections.sort(mProfilesForBillingAddress, new Comparator<AutofillProfile>() {

@Override

public int compare(AutofillProfile a, AutofillProfile b) {

- boolean isAComplete =

- AutofillAddress.checkAddressCompletionStatus(a) == AutofillAddress.COMPLETE;

- boolean isBComplete =

- AutofillAddress.checkAddressCompletionStatus(b) == AutofillAddress.COMPLETE;

+ boolean isAComplete = AutofillAddress.checkAddressCompletionStatus(

+ a, AutofillAddress.NORMAL_COMPLETENESS_CHECK)

+ == AutofillAddress.COMPLETE;

+ boolean isBComplete = AutofillAddress.checkAddressCompletionStatus(

+ b, AutofillAddress.NORMAL_COMPLETENESS_CHECK)

+ == AutofillAddress.COMPLETE;

return ApiCompatibilityUtils.compareBoolean(isBComplete, isAComplete);

}

});