chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java - Issue 2715783004: [Payments] Make phone number optional for billing addresses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java

Issue 2715783004: [Payments] Make phone number optional for billing addresses. (Closed)

Patch Set: Addressed comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java

index ef0826e2c614f41cd8c2d3605e9acc50c5043263..5223f1decce6b4dbd6aa9248e5c7106f8a0efc12 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java

@@ -89,7 +89,8 @@ public class AutofillPaymentInstrument extends PaymentInstrument

InstrumentDetailsCallback callback) {

// The billing address should never be null for a credit card at this point.

assert mBillingAddress != null;

- assert AutofillAddress.checkAddressCompletionStatus(mBillingAddress)

+ assert AutofillAddress.checkAddressCompletionStatus(

+ mBillingAddress, AutofillAddress.IGNORE_PHONE_COMPLETENESS_CHECK)

== AutofillAddress.COMPLETE;

assert mIsComplete;

assert mHasValidNumberAndName;

@@ -260,7 +261,8 @@ public class AutofillPaymentInstrument extends PaymentInstrument

assert card.getBillingAddressId() != null;

assert card.getBillingAddressId().equals(billingAddress.getGUID());

assert card.getIssuerIconDrawableId() != 0;

- assert AutofillAddress.checkAddressCompletionStatus(billingAddress)

+ assert AutofillAddress.checkAddressCompletionStatus(

+ billingAddress, AutofillAddress.IGNORE_PHONE_COMPLETENESS_CHECK)

== AutofillAddress.COMPLETE;

mCard = card;