|
Revert of Avoid two targeting phases in aura client-lib and EventProcessor. (patchset #9 id:220001 of https://codereview.chromium.org/2681613002/ )
Reason for revert:
This patch broke window resizing (specifically when making windows bigger and when mouse event location is outside the window bounds for certain distance) in mash. Will fix this before relanding.
Original issue's description:
> Avoid two targeting phases in aura client-lib and EventProcessor.
>
> 1. Client-lib now skips the step where it converted the event location from
> target window's coordinate system to root window's coordinate system; and
> sets the target window received from mus-ws to be the target for that event.
>
> 2. Added two virtual functions in EventProcessor responsible for getting the
> window with the right targeter (either root window or the farthest ancestor
> with a targeter set) and for getting the default targeter (WindowTargeter)
> respectively.
>
> 3. WindowEventDispatcher now is responsible for finding the right target and
> doing the conversion between their coordinate systems.
>
> 4. WindowTreeHost only sets a targeter for the root window in non-mus mode
> so that we don't end up walking all the way up to the root window just to use
> the default event targeter.
>
> This also solves the bug where we were using DIP for conversion in the
> client-lib but event location was still in pixels at that time.
>
> BUG= 687700
> TEST=aura_unittests
> manual (--force-device-scale-factor=2)
>
> Review-Url: https://codereview.chromium.org/2681613002
> Cr-Commit-Position: refs/heads/master@{#452393}
> Committed: https://chromium.googlesource.com/chromium/src/+/6b3d9805494f966193ad47181d39544d541e79f2
TBR=sadrul@chromium.org,sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 687700
Review-Url: https://codereview.chromium.org/2715743005
Cr-Commit-Position: refs/heads/master@{#452679}
Committed: https://chromium.googlesource.com/chromium/src/+/4e8acf39f19aead0fff12ac584988a29571db65c
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+70 lines, -477 lines) |
Patch |
 |
M |
ash/root_window_controller.cc
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
ash/shelf/shelf_widget_unittest.cc
|
View
|
|
2 chunks |
+4 lines, -6 lines |
0 comments
|
Download
|
 |
M |
ash/wm/immersive_fullscreen_controller_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
ash/wm/overview/window_selector_unittest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
ash/wm/panels/panel_layout_manager_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
ash/wm/workspace_controller_unittest.cc
|
View
|
|
4 chunks |
+8 lines, -12 lines |
0 comments
|
Download
|
 |
M |
ui/aura/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ui/aura/mus/window_tree_client.cc
|
View
|
|
2 chunks |
+16 lines, -12 lines |
0 comments
|
Download
|
 |
M |
ui/aura/mus/window_tree_client_unittest.cc
|
View
|
|
6 chunks |
+10 lines, -223 lines |
0 comments
|
Download
|
 |
M |
ui/aura/test/aura_test_helper.cc
|
View
|
|
2 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
D |
ui/aura/test/test_window_targeter.h
|
View
|
|
1 chunk |
+0 lines, -37 lines |
0 comments
|
Download
|
 |
D |
ui/aura/test/test_window_targeter.cc
|
View
|
|
1 chunk |
+0 lines, -26 lines |
0 comments
|
Download
|
 |
M |
ui/aura/window_event_dispatcher.h
|
View
|
|
3 chunks |
+1 line, -7 lines |
0 comments
|
Download
|
 |
M |
ui/aura/window_event_dispatcher.cc
|
View
|
|
4 chunks |
+2 lines, -36 lines |
0 comments
|
Download
|
 |
M |
ui/aura/window_event_dispatcher_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -44 lines |
0 comments
|
Download
|
 |
M |
ui/aura/window_tree_host.cc
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ui/events/event_processor.h
|
View
|
|
1 chunk |
+2 lines, -9 lines |
0 comments
|
Download
|
 |
M |
ui/events/event_processor.cc
|
View
|
|
2 chunks |
+8 lines, -16 lines |
0 comments
|
Download
|
 |
M |
ui/events/event_processor_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/events/test/test_event_processor.h
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
ui/events/test/test_event_processor.cc
|
View
|
|
2 chunks |
+1 line, -9 lines |
0 comments
|
Download
|
 |
M |
ui/views/bubble/bubble_window_targeter_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ui/views/test/event_generator_delegate_mac.mm
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
ui/views/touchui/touch_selection_controller_impl_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -5 lines |
0 comments
|
Download
|
 |
M |
ui/views/widget/root_view.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
ui/views/widget/root_view.cc
|
View
|
|
1 chunk |
+1 line, -5 lines |
0 comments
|
Download
|
Total messages: 6 (3 generated)
|