Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: ui/events/event_processor.h

Issue 2715743005: Revert of Avoid two targeting phases in aura client-lib and EventProcessor. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/aura/window_tree_host.cc ('k') | ui/events/event_processor.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_EVENTS_EVENT_PROCESSOR_H_ 5 #ifndef UI_EVENTS_EVENT_PROCESSOR_H_
6 #define UI_EVENTS_EVENT_PROCESSOR_H_ 6 #define UI_EVENTS_EVENT_PROCESSOR_H_
7 7
8 #include "ui/events/event_dispatcher.h" 8 #include "ui/events/event_dispatcher.h"
9 #include "ui/events/event_source.h" 9 #include "ui/events/event_source.h"
10 10
11 namespace ui { 11 namespace ui {
12 12
13 class EventTargeter;
14
15 // EventProcessor receives an event from an EventSource and dispatches it to a 13 // EventProcessor receives an event from an EventSource and dispatches it to a
16 // tree of EventTargets. 14 // tree of EventTargets.
17 class EVENTS_EXPORT EventProcessor : public EventDispatcherDelegate { 15 class EVENTS_EXPORT EventProcessor : public EventDispatcherDelegate {
18 public: 16 public:
19 ~EventProcessor() override {} 17 ~EventProcessor() override {}
20 18
21 // Returns the EventTarget with the right EventTargeter that we should use for 19 // Returns the root of the tree this event processor owns.
22 // dispatching this |event|. 20 virtual EventTarget* GetRootTarget() = 0;
23 virtual EventTarget* GetRootForEvent(Event* event) = 0;
24
25 // If the root target returned by GetRootForEvent() does not have a
26 // targeter set, then the default targeter is used to find the target.
27 virtual EventTargeter* GetDefaultEventTargeter() = 0;
28 21
29 // Dispatches an event received from the EventSource to the tree of 22 // Dispatches an event received from the EventSource to the tree of
30 // EventTargets (whose root is returned by GetRootTarget()). The co-ordinate 23 // EventTargets (whose root is returned by GetRootTarget()). The co-ordinate
31 // space of the source must be the same as the root target, except that the 24 // space of the source must be the same as the root target, except that the
32 // target may have a high-dpi scale applied. 25 // target may have a high-dpi scale applied.
33 // TODO(tdanderson|sadrul): This is only virtual for testing purposes. It 26 // TODO(tdanderson|sadrul): This is only virtual for testing purposes. It
34 // should not be virtual at all. 27 // should not be virtual at all.
35 virtual EventDispatchDetails OnEventFromSource(Event* event) 28 virtual EventDispatchDetails OnEventFromSource(Event* event)
36 WARN_UNUSED_RESULT; 29 WARN_UNUSED_RESULT;
37 30
38 protected: 31 protected:
39 // Invoked at the start of processing, before an EventTargeter is used to 32 // Invoked at the start of processing, before an EventTargeter is used to
40 // find the target of the event. If processing should not take place, marks 33 // find the target of the event. If processing should not take place, marks
41 // |event| as handled. Otherwise updates |event| so that the targeter can 34 // |event| as handled. Otherwise updates |event| so that the targeter can
42 // operate correctly (e.g., it can be used to update the location of the 35 // operate correctly (e.g., it can be used to update the location of the
43 // event when dispatching from an EventSource in high-DPI) and updates any 36 // event when dispatching from an EventSource in high-DPI) and updates any
44 // members in the event processor as necessary. 37 // members in the event processor as necessary.
45 virtual void OnEventProcessingStarted(Event* event); 38 virtual void OnEventProcessingStarted(Event* event);
46 39
47 // Invoked when the processing of |event| has finished (i.e., when no further 40 // Invoked when the processing of |event| has finished (i.e., when no further
48 // dispatching of |event| will be performed by this EventProcessor). Note 41 // dispatching of |event| will be performed by this EventProcessor). Note
49 // that the last target to which |event| was dispatched may have been 42 // that the last target to which |event| was dispatched may have been
50 // destroyed. 43 // destroyed.
51 virtual void OnEventProcessingFinished(Event* event); 44 virtual void OnEventProcessingFinished(Event* event);
52 }; 45 };
53 46
54 } // namespace ui 47 } // namespace ui
55 48
56 #endif // UI_EVENTS_EVENT_PROCESSOR_H_ 49 #endif // UI_EVENTS_EVENT_PROCESSOR_H_
OLDNEW
« no previous file with comments | « ui/aura/window_tree_host.cc ('k') | ui/events/event_processor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698