Rename SVGPaintContext::paintSubtree to paintResourceSubtree

Rename SVGPaintContext::paintSubtree to paintResourceSubtree

To better reflect it's use and function.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2715513009
Cr-Commit-Position: refs/heads/master@{#453278}
Committed: https://chromium.googlesource.com/chromium/src/+/d8e1c0b6e41d77182b9500179a49392c9a245a34

[fs, 2017-02-24 15:59:46]

Description was changed from

==========
Fold away SVGPaintContext::paintSubtree

Mostly an odd-ball method on SVGPaintContext. Get rid of it.
==========

to

==========
Fold away SVGPaintContext::paintSubtree

Mostly an odd-ball method on SVGPaintContext. Get rid of it.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2017-02-24 15:59:51]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 16:00:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-02-24 17:24:26]

fs@opera.com changed reviewers:
+ pdr@chromium.org, schenney@chromium.org

[Stephen Chennney, 2017-02-24 17:34:35]

I'm not so happy with this. If we ever have to change the paint info we now have
to do it in 3 places instead of 1.

What does pdr@ think?

[commit-bot: I haz the power, 2017-02-24 17:41:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 17:41:19]

Dry run: This issue passed the CQ dry run.

[fs, 2017-02-24 18:12:13]

On 2017/02/24 at 17:34:35, schenney wrote:
> I'm not so happy with this. If we ever have to change the paint info we now
have to do it in 3 places instead of 1.

Fair enough I guess. I tend to think of it as hiding more than it helps. Maybe I
should just rename it to paintResourceSubtree or so instead?

[Stephen Chennney, 2017-02-24 18:15:15]

On 2017/02/24 18:12:13, fs wrote:
> On 2017/02/24 at 17:34:35, schenney wrote:
> > I'm not so happy with this. If we ever have to change the paint info we now
> have to do it in 3 places instead of 1.
> 
> Fair enough I guess. I tend to think of it as hiding more than it helps. Maybe
I
> should just rename it to paintResourceSubtree or so instead?

I also thought of the renaming. So yes, please go ahead with that.

[fs, 2017-02-24 19:03:47]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 19:04:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-02-24 19:04:57]

Description was changed from

==========
Fold away SVGPaintContext::paintSubtree

Mostly an odd-ball method on SVGPaintContext. Get rid of it.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Rename SVGPaintContext::paintSubtree to paintResourceSubtree

To better reflect it's use and function.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2017-02-24 19:37:27]

On 2017/02/24 at 18:15:15, schenney wrote:
> On 2017/02/24 18:12:13, fs wrote:
> > On 2017/02/24 at 17:34:35, schenney wrote:
> > > I'm not so happy with this. If we ever have to change the paint info we
now
> > have to do it in 3 places instead of 1.
> > 
> > Fair enough I guess. I tend to think of it as hiding more than it helps.
Maybe I
> > should just rename it to paintResourceSubtree or so instead?
> 
> I also thought of the renaming. So yes, please go ahead with that.

Done.

[pdr., 2017-02-24 20:01:53]

On 2017/02/24 at 17:34:35, schenney wrote:
> I'm not so happy with this. If we ever have to change the paint info we now
have to do it in 3 places instead of 1.
> 
> What does pdr@ think?

I think both approaches are good. Sounds like the newest patchset has more
support, so LGTM for that.

[commit-bot: I haz the power, 2017-02-24 20:45:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 20:45:45]

Dry run: This issue passed the CQ dry run.

[fs, 2017-02-27 17:06:00]

On 2017/02/24 at 20:01:53, pdr wrote:
> On 2017/02/24 at 17:34:35, schenney wrote:
> > I'm not so happy with this. If we ever have to change the paint info we now
have to do it in 3 places instead of 1.
> > 
> > What does pdr@ think?
> 
> I think both approaches are good. Sounds like the newest patchset has more
support, so LGTM for that.

schenney?

[Stephen Chennney, 2017-02-27 17:12:43]

On 2017/02/27 17:06:00, fs wrote:
> On 2017/02/24 at 20:01:53, pdr wrote:
> > On 2017/02/24 at 17:34:35, schenney wrote:
> > > I'm not so happy with this. If we ever have to change the paint info we
now
> have to do it in 3 places instead of 1.
> > > 
> > > What does pdr@ think?
> > 
> > I think both approaches are good. Sounds like the newest patchset has more
> support, so LGTM for that.
> 
> schenney?

Sorry, yes, it lgtm.

[fs, 2017-02-27 17:37:36]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2017-02-27 17:37:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 19:04:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488217056895060,
"parent_rev": "6e0dec285733a1c7be98253683d7ed7129290878", "commit_rev":
"d8e1c0b6e41d77182b9500179a49392c9a245a34"}

[commit-bot: I haz the power, 2017-02-27 19:05:06]

Description was changed from

==========
Rename SVGPaintContext::paintSubtree to paintResourceSubtree

To better reflect it's use and function.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Rename SVGPaintContext::paintSubtree to paintResourceSubtree

To better reflect it's use and function.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2715513009
Cr-Commit-Position: refs/heads/master@{#453278}
Committed:
https://chromium.googlesource.com/chromium/src/+/d8e1c0b6e41d77182b9500179a49...
==========

[commit-bot: I haz the power, 2017-02-27 19:05:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d8e1c0b6e41d77182b9500179a49...