Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2715243012: Renames kWindowIgnoredByShelf_Property to ..._InitProperty (Closed)

Created:
3 years, 9 months ago by sky
Modified:
3 years, 9 months ago
Reviewers:
Tom Sepez, James Cook
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renames kWindowIgnoredByShelf_Property to ..._InitProperty We only need to set this during initial window creation, so set rename the property appropriately and update code as appropiate. BUG=671729 TEST=none R=jamescook@chromium.org, tsepez@chromium.org Review-Url: https://codereview.chromium.org/2715243012 Cr-Commit-Position: refs/heads/master@{#453843} Committed: https://chromium.googlesource.com/chromium/src/+/003bccb313db261e4439ebf2adb8f5dcb13710a9

Patch Set 1 #

Total comments: 2

Patch Set 2 : init #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -27 lines) Patch
M ash/mus/top_level_window_factory.cc View 1 chunk +13 lines, -10 lines 0 comments Download
M ash/mus/window_manager.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M services/ui/public/interfaces/window_manager.mojom View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
sky
3 years, 9 months ago (2017-02-28 22:19:28 UTC) #2
James Cook
LGTM with nit https://codereview.chromium.org/2715243012/diff/1/services/ui/public/interfaces/window_manager.mojom File services/ui/public/interfaces/window_manager.mojom (right): https://codereview.chromium.org/2715243012/diff/1/services/ui/public/interfaces/window_manager.mojom#newcode65 services/ui/public/interfaces/window_manager.mojom:65: "prop:window-ignored-by-shelf"; Should this be "init:" instead ...
3 years, 9 months ago (2017-03-01 00:11:17 UTC) #7
sky
+tsepez for mojom https://codereview.chromium.org/2715243012/diff/1/services/ui/public/interfaces/window_manager.mojom File services/ui/public/interfaces/window_manager.mojom (right): https://codereview.chromium.org/2715243012/diff/1/services/ui/public/interfaces/window_manager.mojom#newcode65 services/ui/public/interfaces/window_manager.mojom:65: "prop:window-ignored-by-shelf"; On 2017/03/01 00:11:17, James Cook ...
3 years, 9 months ago (2017-03-01 00:20:50 UTC) #11
Tom Sepez
lgtm
3 years, 9 months ago (2017-03-01 00:35:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715243012/20001
3 years, 9 months ago (2017-03-01 04:11:10 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 04:49:17 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/003bccb313db261e4439ebf2adb8...

Powered by Google App Engine
This is Rietveld 408576698