Renames kWindowIgnoredByShelf_Property to ..._InitProperty

services/ui/public/interfaces/window_manager.mojom

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module ui.mojom;
 
 import "services/ui/public/interfaces/cursor.mojom";
 import "services/ui/public/interfaces/event_matcher.mojom";
 import "services/ui/public/interfaces/window_manager_constants.mojom";
 import "services/ui/public/interfaces/window_tree_constants.mojom";
@@ skipping 42 matching lines @@
   const string kDisableImmersive_InitProperty = "init:disable_immersive";
 
   // The id of the display (display::Display::id()) to create the window on.
   // Type: int64.
   const string kDisplayId_InitProperty = "init:display_id";
 
   // Specifies that the system default caption and icon should not be rendered,
   // and the client area should be equivalent to the window area. Type: bool
   const string kRemoveStandardFrame_InitProperty = "init:remove-standard-frame";
 
+  // A flag controlling the window's presence on the mash shelf. Type: bool
+  const string kWindowIgnoredByShelf_InitProperty =
+      "prop:window-ignored-by-shelf";

[James Cook, 2017/03/01 00:11:17]

Should this be "init:" instead of "prop:" like the others?

[sky, 2017/03/01 00:20:49]

Good point. Done.

+
   // The window type. This maps to aura::client::kWindowTypeKey as well as
   // Window::type(). This mapping is only done for top-level windows that are
   // created by the window manager at the request of a client.
   // Type: mojom::WindowType (int32_t).
   const string kWindowType_InitProperty = "init:window-type";
 
   // End properties used only during creation time. ----------------------------
 
   // Long lived properties. ----------------------------------------------------
 
@@ skipping 55 matching lines @@
   // A few ash::ShelfItemType values are supported; TYPE_UNKNOWN means no item.
   const string kShelfItemType_Property = "prop:shelf-item-type";
 
   // The window's show state. Maps to aura::client::kShowStateKey.
   // Type: ShowState.
   const string kShowState_Property = "prop:show-state";
 
   // The window icon; typically 16x16 for titlebars. Type: SkBitmap
   const string kWindowIcon_Property = "prop:window-icon";
 
-  // A flag controlling the window's presence on the mash shelf. Type: bool
-  // TODO: convert this to a aura::client property; http://crbug.com/671729.
-  const string kWindowIgnoredByShelf_Property = "prop:window-ignored-by-shelf";
-
   // The window's title. Maps to aura::client::kTitleKey. Type: mojom::String
   const string kWindowTitle_Property = "prop:window-title";
 
   // End long lived properties. ------------------------------------------------
 
   // Shadow style for the window. Type: mojom::ShadowStyle.
   // TODO(sky): this is currently unused, either wire up or nuke:
   // http://crbug.com/671714.
   const string kShadowStyle_Property = "prop:shadow-style";
 
@@ skipping 111 matching lines @@
   WmSetNonClientCursor(uint32 window_id, Cursor cursor_id);
 
   // Response from WmCreateTopLevelWindow() informing the client of the id for
   // the new window.
   OnWmCreatedTopLevelWindow(uint32 change_id, uint32 window_id);
 
   // See description in WindowManager::OnAccelerator(). |ack_id| is the value
   // that was passed to OnAccelerator().
   OnAcceleratorAck(uint32 ack_id, EventResult event_result);
 };