Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: chrome/browser/ui/views/status_bubble_views.cc

Issue 2715243012: Renames kWindowIgnoredByShelf_Property to ..._InitProperty (Closed)
Patch Set: init Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/status_bubble_views.h" 5 #include "chrome/browser/ui/views/status_bubble_views.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/i18n/rtl.h" 10 #include "base/i18n/rtl.h"
(...skipping 637 matching lines...) Expand 10 before | Expand all | Expand 10 after
648 // revert this change once http://crbug.com/125248 is fixed. 648 // revert this change once http://crbug.com/125248 is fixed.
649 params.force_software_compositing = true; 649 params.force_software_compositing = true;
650 #endif 650 #endif
651 params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW; 651 params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;
652 params.accept_events = false; 652 params.accept_events = false;
653 params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET; 653 params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
654 params.parent = frame->GetNativeView(); 654 params.parent = frame->GetNativeView();
655 params.context = frame->GetNativeWindow(); 655 params.context = frame->GetNativeWindow();
656 #if defined(USE_AURA) 656 #if defined(USE_AURA)
657 params.mus_properties 657 params.mus_properties
658 [ui::mojom::WindowManager::kWindowIgnoredByShelf_Property] = 658 [ui::mojom::WindowManager::kWindowIgnoredByShelf_InitProperty] =
659 mojo::ConvertTo<std::vector<uint8_t>>(true); 659 mojo::ConvertTo<std::vector<uint8_t>>(true);
660 #endif 660 #endif
661 popup_->Init(params); 661 popup_->Init(params);
662 // We do our own animation and don't want any from the system. 662 // We do our own animation and don't want any from the system.
663 popup_->SetVisibilityChangedAnimationsEnabled(false); 663 popup_->SetVisibilityChangedAnimationsEnabled(false);
664 popup_->SetOpacity(0.f); 664 popup_->SetOpacity(0.f);
665 popup_->SetContentsView(view_); 665 popup_->SetContentsView(view_);
666 #if defined(USE_ASH) 666 #if defined(OS_CHROMEOS)
667 // TODO: http://crbug.com/671729 convert to WindowProperty (and then can
668 // remove explicit kWindowIgnoredByShelf_Property above and make this ifdef
669 // USE_AURA).
670 if (!service_manager::ServiceManagerIsRemote()) { 667 if (!service_manager::ServiceManagerIsRemote()) {
671 ash::wm::GetWindowState(popup_->GetNativeWindow()) 668 ash::wm::GetWindowState(popup_->GetNativeWindow())
672 ->set_ignored_by_shelf(true); 669 ->set_ignored_by_shelf(true);
673 } 670 }
674 #endif 671 #endif
675 RepositionPopup(); 672 RepositionPopup();
676 } 673 }
677 } 674 }
678 675
679 void StatusBubbleViews::Reposition() { 676 void StatusBubbleViews::Reposition() {
(...skipping 271 matching lines...) Expand 10 before | Expand all | Expand 10 after
951 void StatusBubbleViews::SetBubbleWidth(int width) { 948 void StatusBubbleViews::SetBubbleWidth(int width) {
952 size_.set_width(width); 949 size_.set_width(width);
953 SetBounds(original_position_.x(), original_position_.y(), 950 SetBounds(original_position_.x(), original_position_.y(),
954 size_.width(), size_.height()); 951 size_.width(), size_.height());
955 } 952 }
956 953
957 void StatusBubbleViews::CancelExpandTimer() { 954 void StatusBubbleViews::CancelExpandTimer() {
958 if (expand_timer_factory_.HasWeakPtrs()) 955 if (expand_timer_factory_.HasWeakPtrs())
959 expand_timer_factory_.InvalidateWeakPtrs(); 956 expand_timer_factory_.InvalidateWeakPtrs();
960 } 957 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc ('k') | services/ui/public/interfaces/window_manager.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698