Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2715233002: //third_party/WebKit/Source/modules: include v8 as a user, not system, header (Closed)

Created:
3 years, 9 months ago by dcheng
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, tzik, johnme+watch_chromium.org, jsbell+serviceworker_chromium.org, awdf+watch_chromium.org, yhirano+watch_chromium.org, wanming.lin, blink-reviews, falken+watch_chromium.org, harkness+watch_chromium.org, Peter Beverloo, nhiroki, jsbell+idb_chromium.org, michaeln, shimazu+serviceworker_chromium.org, tyoshino+watch_chromium.org, shalamov, serviceworker-reviews, kinuko+serviceworker, cmumford, horo+watch_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

//third_party/WebKit/Source/modules: include v8 as a user, not system, header Note: due to an issue with v8's GN files, files that use include v8 inspector headers are being skipped for now. BUG=688155 Review-Url: https://codereview.chromium.org/2715233002 Cr-Commit-Position: refs/heads/master@{#453185} Committed: https://chromium.googlesource.com/chromium/src/+/7a6450fb88ac73ce0eea958f97e6c304011d1caa

Patch Set 1 #

Patch Set 2 : Revert things that use inspector headers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -35 lines) Patch
M third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/ReadableStreamBytesConsumer.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/ReadableStreamBytesConsumerTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBValue.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorErrorEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/time_zone_monitor/TimeZoneMonitorClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
dcheng
3 years, 9 months ago (2017-02-27 08:57:44 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-02-27 09:05:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715233002/20001
3 years, 9 months ago (2017-02-27 09:24:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715233002/20001
3 years, 9 months ago (2017-02-27 09:37:13 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 11:04:13 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7a6450fb88ac73ce0eea958f97e6...

Powered by Google App Engine
This is Rietveld 408576698