third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp - Issue 2715233002: //third_party/WebKit/Source/modules: include v8 as a user, not system, header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

Issue 2715233002: //third_party/WebKit/Source/modules: include v8 as a user, not system, header (Closed)

Patch Set: Revert things that use inspector headers. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp ('k') | third_party/WebKit/Source/modules/sensor/SensorErrorEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp b/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

index 92a5eeb6eda4fc572e753891e38039a2fed2f51d..c1d0ab6b3823469034d48ffd768270b1302bada1 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

+++ b/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

@@ -4,6 +4,8 @@

#include "modules/push_messaging/PushMessageData.h"

+#include <memory>

#include "bindings/core/v8/ExceptionState.h"

#include "bindings/core/v8/ScriptState.h"

#include "bindings/core/v8/V8Binding.h"

@@ -11,10 +13,9 @@

#include "core/dom/DOMArrayBuffer.h"

#include "core/fileapi/Blob.h"

#include "platform/blob/BlobData.h"

+#include "v8/include/v8.h"

#include "wtf/Assertions.h"

#include "wtf/text/TextEncoding.h"

-#include <memory>

-#include <v8.h>

namespace blink {