third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp - Issue 2715233002: //third_party/WebKit/Source/modules: include v8 as a user, not system, header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

Issue 2715233002: //third_party/WebKit/Source/modules: include v8 as a user, not system, header (Closed)

Patch Set: Revert things that use inspector headers. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

index f966a026d92b0fb94a97bd9c2e160713685b6db7..615342cc3ed0d85236e8aa889b122349677cadf7 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

@@ -5,6 +5,9 @@

#include "modules/serviceworkers/ServiceWorkerContainer.h"

+#include <memory>

+#include <utility>

#include "bindings/core/v8/Dictionary.h"

#include "bindings/core/v8/ScriptFunction.h"

#include "bindings/core/v8/ScriptPromise.h"

@@ -24,11 +27,9 @@

#include "public/platform/modules/serviceworker/WebServiceWorkerClientsInfo.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerProvider.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include "v8/include/v8.h"

#include "wtf/PtrUtil.h"

#include "wtf/text/WTFString.h"

-#include <memory>

-#include <utility>

-#include <v8.h>

namespace blink {

namespace {