Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 2714113003: Move ownership of IdleSpellCheckCallback from LocalFrame to SpellChecker (Closed)

Created:
3 years, 10 months ago by Xiaocheng
Modified:
3 years, 9 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, kinuko+watch, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ownership of IdleSpellCheckCallback from LocalFrame to SpellChecker IdleSpellCheckCallback is an implementation detail of Blink's SpellChecker, and should better be owned by and hidden in SpellChecker, instead of being exposed from LocalFrame. This patch hence moves ownership of IdleSpellCheckCallback to SpellChecker. BUG=517298, 695359 Review-Url: https://codereview.chromium.org/2714113003 Cr-Commit-Position: refs/heads/master@{#453157} Committed: https://chromium.googlesource.com/chromium/src/+/d9e6a0b2197094e8fd4b4f4cb66f19bdfd213403

Patch Set 1 #

Patch Set 2 : Fri Feb 24 11:06:25 PST 2017 #

Messages

Total messages: 20 (14 generated)
Xiaocheng
PTAL. This patch follows the discussion in https://codereview.chromium.org/2701983002.
3 years, 10 months ago (2017-02-24 23:01:38 UTC) #9
yosin_UTC9
lgtm Thanks for quick work!
3 years, 10 months ago (2017-02-25 00:52:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714113003/20001
3 years, 10 months ago (2017-02-25 01:02:32 UTC) #13
tkent
lgtm
3 years, 9 months ago (2017-02-26 20:37:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2714113003/20001
3 years, 9 months ago (2017-02-27 03:24:21 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 05:21:56 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d9e6a0b2197094e8fd4b4f4cb66f...

Powered by Google App Engine
This is Rietveld 408576698