Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

Issue 2714113003: Move ownership of IdleSpellCheckCallback from LocalFrame to SpellChecker (Closed)
Patch Set: Fri Feb 24 11:06:25 PST 2017 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 18 matching lines...) Expand all
29 #include "core/CoreExport.h" 29 #include "core/CoreExport.h"
30 #include "core/editing/FrameSelection.h" 30 #include "core/editing/FrameSelection.h"
31 #include "core/editing/VisibleSelection.h" 31 #include "core/editing/VisibleSelection.h"
32 #include "core/editing/markers/DocumentMarker.h" 32 #include "core/editing/markers/DocumentMarker.h"
33 #include "platform/heap/Handle.h" 33 #include "platform/heap/Handle.h"
34 #include "platform/text/TextChecking.h" 34 #include "platform/text/TextChecking.h"
35 35
36 namespace blink { 36 namespace blink {
37 37
38 class CompositeEditCommand; 38 class CompositeEditCommand;
39 class IdleSpellCheckCallback;
39 class LocalFrame; 40 class LocalFrame;
40 class ReplaceSelectionCommand; 41 class ReplaceSelectionCommand;
41 class SpellCheckerClient; 42 class SpellCheckerClient;
42 class SpellCheckRequest; 43 class SpellCheckRequest;
43 class SpellCheckRequester; 44 class SpellCheckRequester;
44 class TextCheckerClient; 45 class TextCheckerClient;
45 class TextCheckingParagraph; 46 class TextCheckingParagraph;
46 struct TextCheckingResult; 47 struct TextCheckingResult;
47 class TypingCommand; 48 class TypingCommand;
48 49
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 void removeMarkers(const VisibleSelection&, DocumentMarker::MarkerTypes); 122 void removeMarkers(const VisibleSelection&, DocumentMarker::MarkerTypes);
122 123
123 void markMisspellingsInternal(const VisibleSelection&); 124 void markMisspellingsInternal(const VisibleSelection&);
124 void chunkAndMarkAllMisspellings( 125 void chunkAndMarkAllMisspellings(
125 const TextCheckingParagraph& fullParagraphToCheck); 126 const TextCheckingParagraph& fullParagraphToCheck);
126 void spellCheckOldSelection(const Position& oldSelectionStart, 127 void spellCheckOldSelection(const Position& oldSelectionStart,
127 const VisibleSelection& newAdjacentWords); 128 const VisibleSelection& newAdjacentWords);
128 129
129 Member<LocalFrame> m_frame; 130 Member<LocalFrame> m_frame;
130 131
131 // TODO(xiaochengh): Move it to IdleSpellCheckCallback after idle time spell
132 // checking reaches status=stable.
133 const Member<SpellCheckRequester> m_spellCheckRequester; 132 const Member<SpellCheckRequester> m_spellCheckRequester;
133 const Member<IdleSpellCheckCallback> m_idleSpellCheckCallback;
134 }; 134 };
135 135
136 } // namespace blink 136 } // namespace blink
137 137
138 #endif // SpellChecker_h 138 #endif // SpellChecker_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698