Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Side by Side Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2714113003: Move ownership of IdleSpellCheckCallback from LocalFrame to SpellChecker (Closed)
Patch Set: Fri Feb 24 11:06:25 PST 2017 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
9 * reserved. 9 * reserved.
10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 template <typename Traversal> 51 template <typename Traversal>
52 class EditingAlgorithm; 52 class EditingAlgorithm;
53 class Element; 53 class Element;
54 template <typename Strategy> 54 template <typename Strategy>
55 class EphemeralRangeTemplate; 55 class EphemeralRangeTemplate;
56 class EventHandler; 56 class EventHandler;
57 class FloatSize; 57 class FloatSize;
58 class FrameConsole; 58 class FrameConsole;
59 class FrameSelection; 59 class FrameSelection;
60 class FrameView; 60 class FrameView;
61 class IdleSpellCheckCallback;
62 class InputMethodController; 61 class InputMethodController;
63 class InstrumentingAgents; 62 class InstrumentingAgents;
64 class InterfaceProvider; 63 class InterfaceProvider;
65 class InterfaceRegistry; 64 class InterfaceRegistry;
66 class IntPoint; 65 class IntPoint;
67 class IntSize; 66 class IntSize;
68 class LayoutView; 67 class LayoutView;
69 class LayoutViewItem; 68 class LayoutViewItem;
70 class LocalDOMWindow; 69 class LocalDOMWindow;
71 class LocalFrameClient; 70 class LocalFrameClient;
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 138
140 Editor& editor() const; 139 Editor& editor() const;
141 EventHandler& eventHandler() const; 140 EventHandler& eventHandler() const;
142 FrameLoader& loader() const; 141 FrameLoader& loader() const;
143 NavigationScheduler& navigationScheduler() const; 142 NavigationScheduler& navigationScheduler() const;
144 FrameSelection& selection() const; 143 FrameSelection& selection() const;
145 InputMethodController& inputMethodController() const; 144 InputMethodController& inputMethodController() const;
146 ScriptController& script() const; 145 ScriptController& script() const;
147 SpellChecker& spellChecker() const; 146 SpellChecker& spellChecker() const;
148 FrameConsole& console() const; 147 FrameConsole& console() const;
149 IdleSpellCheckCallback& idleSpellCheckCallback() const;
150 148
151 // This method is used to get the highest level LocalFrame in this 149 // This method is used to get the highest level LocalFrame in this
152 // frame's in-process subtree. 150 // frame's in-process subtree.
153 // FIXME: This is a temporary hack to support RemoteFrames, and callers 151 // FIXME: This is a temporary hack to support RemoteFrames, and callers
154 // should be updated to avoid storing things on the main frame. 152 // should be updated to avoid storing things on the main frame.
155 LocalFrame* localFrameRoot(); 153 LocalFrame* localFrameRoot();
156 154
157 // Note that the result of this function should not be cached: a frame is 155 // Note that the result of this function should not be cached: a frame is
158 // not necessarily detached when it is navigated, so the return value can 156 // not necessarily detached when it is navigated, so the return value can
159 // change. 157 // change.
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 // Usually 0. Non-null if this is the top frame of PagePopup. 253 // Usually 0. Non-null if this is the top frame of PagePopup.
256 Member<Element> m_pagePopupOwner; 254 Member<Element> m_pagePopupOwner;
257 255
258 const Member<ScriptController> m_script; 256 const Member<ScriptController> m_script;
259 const Member<Editor> m_editor; 257 const Member<Editor> m_editor;
260 const Member<SpellChecker> m_spellChecker; 258 const Member<SpellChecker> m_spellChecker;
261 const Member<FrameSelection> m_selection; 259 const Member<FrameSelection> m_selection;
262 const Member<EventHandler> m_eventHandler; 260 const Member<EventHandler> m_eventHandler;
263 const Member<FrameConsole> m_console; 261 const Member<FrameConsole> m_console;
264 const Member<InputMethodController> m_inputMethodController; 262 const Member<InputMethodController> m_inputMethodController;
265 const Member<IdleSpellCheckCallback> m_idleSpellCheckCallback;
266 263
267 int m_navigationDisableCount; 264 int m_navigationDisableCount;
268 265
269 float m_pageZoomFactor; 266 float m_pageZoomFactor;
270 float m_textZoomFactor; 267 float m_textZoomFactor;
271 268
272 bool m_inViewSourceMode; 269 bool m_inViewSourceMode;
273 270
274 Member<InstrumentingAgents> m_instrumentingAgents; 271 Member<InstrumentingAgents> m_instrumentingAgents;
275 Member<PerformanceMonitor> m_performanceMonitor; 272 Member<PerformanceMonitor> m_performanceMonitor;
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 322
326 inline void LocalFrame::setInViewSourceMode(bool mode) { 323 inline void LocalFrame::setInViewSourceMode(bool mode) {
327 m_inViewSourceMode = mode; 324 m_inViewSourceMode = mode;
328 } 325 }
329 326
330 inline EventHandler& LocalFrame::eventHandler() const { 327 inline EventHandler& LocalFrame::eventHandler() const {
331 ASSERT(m_eventHandler); 328 ASSERT(m_eventHandler);
332 return *m_eventHandler; 329 return *m_eventHandler;
333 } 330 }
334 331
335 inline IdleSpellCheckCallback& LocalFrame::idleSpellCheckCallback() const {
336 DCHECK(m_idleSpellCheckCallback);
337 return *m_idleSpellCheckCallback;
338 }
339
340 DEFINE_TYPE_CASTS(LocalFrame, 332 DEFINE_TYPE_CASTS(LocalFrame,
341 Frame, 333 Frame,
342 localFrame, 334 localFrame,
343 localFrame->isLocalFrame(), 335 localFrame->isLocalFrame(),
344 localFrame.isLocalFrame()); 336 localFrame.isLocalFrame());
345 337
346 DECLARE_WEAK_IDENTIFIER_MAP(LocalFrame); 338 DECLARE_WEAK_IDENTIFIER_MAP(LocalFrame);
347 339
348 class FrameNavigationDisabler { 340 class FrameNavigationDisabler {
349 WTF_MAKE_NONCOPYABLE(FrameNavigationDisabler); 341 WTF_MAKE_NONCOPYABLE(FrameNavigationDisabler);
(...skipping 29 matching lines...) Expand all
379 explicit ScopedFrameBlamer(LocalFrame*); 371 explicit ScopedFrameBlamer(LocalFrame*);
380 ~ScopedFrameBlamer(); 372 ~ScopedFrameBlamer();
381 373
382 private: 374 private:
383 Member<LocalFrame> m_frame; 375 Member<LocalFrame> m_frame;
384 }; 376 };
385 377
386 } // namespace blink 378 } // namespace blink
387 379
388 #endif // LocalFrame_h 380 #endif // LocalFrame_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698