Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2713553006: cros: Remove unused WizardController::Observer. (Closed)

Created:
3 years, 10 months ago by jdufault
Modified:
3 years, 9 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Remove unused WizardController::Observer. Details about screen changes should be fully encapsulated within WizardController. BUG=672142 Review-Url: https://codereview.chromium.org/2713553006 Cr-Commit-Position: refs/heads/master@{#453377} Committed: https://chromium.googlesource.com/chromium/src/+/e853fed56dd2eee26d9ead959380c6e4d89a4c99

Patch Set 1 : Initial upload #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 3 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (17 generated)
jdufault
achuith@ PTAL.
3 years, 10 months ago (2017-02-23 23:00:32 UTC) #8
achuithb
lgtm
3 years, 10 months ago (2017-02-24 10:12:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2713553006/40001
3 years, 9 months ago (2017-02-27 22:41:22 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 23:10:05 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e853fed56dd2eee26d9ead959380...

Powered by Google App Engine
This is Rietveld 408576698