Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Issue 2705363002: cros: Move BaseScreenDelegate::ExitCodes into separate file, ScreenExitCode. (Closed)

Created:
3 years, 10 months ago by jdufault
Modified:
3 years, 9 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Move BaseScreenDelegate::ExitCodes into separate file, ScreenExitCode. This CL also logs exit codes as strings instead of as ints. BUG=672142 Review-Url: https://codereview.chromium.org/2705363002 Cr-Commit-Position: refs/heads/master@{#453360} Committed: https://chromium.googlesource.com/chromium/src/+/9c1c3fb361133055cc5ad2aa0009b7118b909a11

Patch Set 1 : Initial upload #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -176 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/base_screen.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/base_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/base_screen_delegate.h View 2 chunks +3 lines, -39 lines 0 comments Download
M chrome/browser/chromeos/login/screens/controller_pairing_screen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/enable_debugging_screen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/eula_screen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/hid_detection_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/host_pairing_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/kiosk_autolaunch_screen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/kiosk_enable_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/mock_base_screen_delegate.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen_browsertest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/reset_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/chromeos/login/screens/screen_exit_code.h View 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/screens/screen_exit_code.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/terms_of_service_screen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen_browsertest.cc View 8 chunks +22 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/wrong_hwid_screen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 2 chunks +27 lines, -27 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 33 chunks +51 lines, -53 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (18 generated)
jdufault
alemate@ PTAL.
3 years, 10 months ago (2017-02-23 23:00:05 UTC) #12
jdufault
oops - fixed the email.
3 years, 10 months ago (2017-02-23 23:01:58 UTC) #14
Alexander Alekseev
lgtm
3 years, 9 months ago (2017-02-27 21:20:41 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705363002/40001
3 years, 9 months ago (2017-02-27 21:27:23 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 22:30:06 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9c1c3fb361133055cc5ad2aa0009...

Powered by Google App Engine
This is Rietveld 408576698