Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2709103005: cros: Move KeyboardDrivenOobeHandler into login_display_host_impl.cc. (Closed)

Created:
3 years, 10 months ago by jdufault
Modified:
3 years, 9 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Move KeyboardDrivenOobeHandler into login_display_host_impl.cc. It's an implementation detail that doesn't need to be exposed. BUG=672142 Review-Url: https://codereview.chromium.org/2709103005 Cr-Commit-Position: refs/heads/master@{#453420} Committed: https://chromium.googlesource.com/chromium/src/+/3cb9fa02e282b950b408a934d98d89c088b87cfc

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -59 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/login/ui/keyboard_driven_oobe_key_handler.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/chromeos/login/ui/keyboard_driven_oobe_key_handler.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 4 chunks +25 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (14 generated)
jdufault
achuith@ PTAL.
3 years, 10 months ago (2017-02-23 23:01:11 UTC) #7
achuithb
lgtm
3 years, 10 months ago (2017-02-24 10:15:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709103005/20001
3 years, 9 months ago (2017-02-27 23:11:28 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 00:43:26 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3cb9fa02e282b950b408a934d98d...

Powered by Google App Engine
This is Rietveld 408576698