|
Simplify/Cleanup MediaClient
This CL does a number of things to cleanup MediaClient's
implementation and usage. This clears the way for an expanded role
in describing MediaCapabilities.
Remove CastMediaClient. Merge methods into CastContentRenderClient.
ContentRenderClient is now the one-stop-shop for embedder
customization. I initially explored giving each embedder its own
MediaClient, but this ended up splitting media customization
between ContentRenderClient and MediaClient (some customization is
too high level to move to MediaClient). The current route is also
less code.
Remove all Chrome specific logic from RenderMediaClient.
RenderMediaClient is now the plumbing for *all* content embedder
customizations to be visible in media/. Chrome is just one of many
embedders and much of the chrome specific code was stale anyway.
Remove KeySystemNameForUMA from MediaClient interface
Decentralizing this logic was overly complicated.
Now centralized to key_systems.cc.
Other little cleanups
Centralize all media/ Rappor usage in MediaLog.
Move cast key_systems_cast into chromecast/renderer/media.
Simplify key_systems_unittest.cc
BUG= 695264
Review-Url: https://codereview.chromium.org/2712983004
Cr-Commit-Position: refs/heads/master@{#463025}
Committed: https://chromium.googlesource.com/chromium/src/+/8aeee0b5c65d2ea16d2c52839cf80bcf99273555
Total comments: 6
Total comments: 6
Total comments: 10
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+534 lines, -871 lines) |
Patch |
|
M |
chrome/renderer/BUILD.gn
|
View
|
1
2
3
4
5
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/renderer/chrome_content_renderer_client.h
|
View
|
1
2
3
4
5
|
3 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/renderer/chrome_content_renderer_client.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
2 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
|
A |
chrome/renderer/media/chrome_key_systems_provider.h
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+68 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/renderer/media/chrome_key_systems_provider.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+83 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/renderer/media/chrome_key_systems_provider_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+155 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/test/BUILD.gn
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chromecast/common/media/BUILD.gn
|
View
|
1
|
1 chunk |
+5 lines, -15 lines |
0 comments
|
Download
|
|
D |
chromecast/common/media/cast_media_client.h
|
View
|
1
2
|
1 chunk |
+0 lines, -52 lines |
0 comments
|
Download
|
|
D |
chromecast/common/media/cast_media_client.cc
|
View
|
1
2
|
1 chunk |
+0 lines, -101 lines |
0 comments
|
Download
|
|
M |
chromecast/renderer/BUILD.gn
|
View
|
1
|
3 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
chromecast/renderer/cast_content_renderer_client.h
|
View
|
1
2
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chromecast/renderer/cast_content_renderer_client.cc
|
View
|
1
2
|
3 chunks |
+49 lines, -7 lines |
0 comments
|
Download
|
|
D |
chromecast/renderer/key_systems_cast.h
|
View
|
1
|
1 chunk |
+0 lines, -27 lines |
0 comments
|
Download
|
|
D |
chromecast/renderer/key_systems_cast.cc
|
View
|
1
|
1 chunk |
+0 lines, -131 lines |
0 comments
|
Download
|
|
M |
chromecast/renderer/media/BUILD.gn
|
View
|
1
2
|
1 chunk |
+9 lines, -0 lines |
0 comments
|
Download
|
|
A + |
chromecast/renderer/media/key_systems_cast.h
|
View
|
1
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
A + |
chromecast/renderer/media/key_systems_cast.cc
|
View
|
1
|
6 chunks |
+7 lines, -8 lines |
0 comments
|
Download
|
|
M |
components/cdm/renderer/android_key_systems.cc
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/public/renderer/content_renderer_client.h
|
View
|
1
2
3
4
5
|
2 chunks |
+14 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/public/renderer/content_renderer_client.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+16 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/render_media_client.h
|
View
|
1
2
|
2 chunks |
+7 lines, -34 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/render_media_client.cc
|
View
|
1
2
|
1 chunk |
+9 lines, -81 lines |
0 comments
|
Download
|
|
D |
content/renderer/media/render_media_client_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -184 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webmediaplayer_ms.cc
|
View
|
1
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/renderer/render_frame_impl.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
3 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/renderer/render_frame_impl.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
6 chunks |
+14 lines, -7 lines |
0 comments
|
Download
|
|
M |
content/test/BUILD.gn
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
media/base/key_systems.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
7 chunks |
+15 lines, -28 lines |
0 comments
|
Download
|
|
M |
media/base/key_systems_unittest.cc
|
View
|
1
2
3
|
10 chunks |
+6 lines, -91 lines |
0 comments
|
Download
|
|
M |
media/base/media_client.h
|
View
|
1
2
3
|
2 chunks |
+8 lines, -31 lines |
0 comments
|
Download
|
|
M |
media/base/media_client.cc
|
View
|
2
3
|
1 chunk |
+0 lines, -9 lines |
0 comments
|
Download
|
|
M |
media/base/media_log.h
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
media/blink/webencryptedmediaclient_impl.h
|
View
|
1
|
4 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
media/blink/webencryptedmediaclient_impl.cc
|
View
|
1
2
3
4
|
3 chunks |
+7 lines, -11 lines |
0 comments
|
Download
|
|
M |
media/blink/webmediaplayer_impl.cc
|
View
|
1
2
3
4
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
media/blink/webmediaplayer_util.h
|
View
|
1
2
3
4
|
3 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
|
M |
media/blink/webmediaplayer_util.cc
|
View
|
1
2
3
4
|
3 chunks |
+18 lines, -30 lines |
0 comments
|
Download
|
Total messages: 116 (74 generated)
|