Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2712983004: Simplify/Cleanup MediaClient (Closed)
Patch Set: Fix test leak Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 08a77e2290a517292c0844a5ea6781195b74cf5b..e3f729bffa7fd3d735e8ee812ad5921d6a6645bc 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2798,6 +2798,15 @@ blink::WebPlugin* RenderFrameImpl::createPlugin(
#endif // BUILDFLAG(ENABLE_PLUGINS)
}
+const scoped_refptr<RenderMediaLog>& RenderFrameImpl::GetMediaLog() {
+ if (!media_log_.get()) {
+ media_log_ =
+ new RenderMediaLog(url::Origin(frame_->getSecurityOrigin()).GetURL());
+ }
+
+ return media_log_;
+}
+
blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
const blink::WebMediaPlayerSource& source,
WebMediaPlayerClient* client,
@@ -2833,9 +2842,6 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
&GetSharedMainThreadContext3D,
RenderThreadImpl::current()->SharedMainThreadContextProvider());
- scoped_refptr<media::MediaLog> media_log(
- new RenderMediaLog(url::Origin(frame_->getSecurityOrigin()).GetURL()));
-
bool embedded_media_experience_enabled = false;
#if defined(OS_ANDROID)
if (!UseMediaPlayerRenderer(url) && !media_surface_manager_)
@@ -2865,7 +2871,8 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
base::Unretained(GetContentClient()->renderer()),
static_cast<RenderFrame*>(this),
GetWebMediaPlayerDelegate()->has_played_media()),
- audio_renderer_sink, media_log, render_thread->GetMediaThreadTaskRunner(),
+ audio_renderer_sink, GetMediaLog(),
+ render_thread->GetMediaThreadTaskRunner(),
render_thread->GetWorkerTaskRunner(),
render_thread->compositor_task_runner(), context_3d_cb,
base::Bind(&v8::Isolate::AdjustAmountOfExternalAllocatedMemory,
@@ -2904,7 +2911,7 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kDisableMojoRenderer)) {
media_renderer_factory = base::MakeUnique<media::DefaultRendererFactory>(
- media_log, GetDecoderFactory(),
+ GetMediaLog(), GetDecoderFactory(),
base::Bind(&RenderThreadImpl::GetGpuFactories,
base::Unretained(render_thread)));
}
@@ -2917,7 +2924,7 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
}
#else
media_renderer_factory = base::MakeUnique<media::DefaultRendererFactory>(
- media_log, GetDecoderFactory(),
+ GetMediaLog(), GetDecoderFactory(),
base::Bind(&RenderThreadImpl::GetGpuFactories,
base::Unretained(render_thread)));
#endif // defined(ENABLE_MOJO_RENDERER)
@@ -4656,7 +4663,7 @@ blink::WebEncryptedMediaClient* RenderFrameImpl::encryptedMediaClient() {
// callback.
base::Bind(&RenderFrameImpl::AreSecureCodecsSupported,
base::Unretained(this)),
- GetCdmFactory(), GetMediaPermission()));
+ GetCdmFactory(), GetMediaPermission(), GetMediaLog()));
}
return web_encrypted_media_client_.get();
}
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698