content/renderer/media/webmediaplayer_ms.cc - Issue 2712983004: Simplify/Cleanup MediaClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediaplayer_ms.cc

Issue 2712983004: Simplify/Cleanup MediaClient (Closed)

Patch Set: Fix test leak Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/webmediaplayer_ms.cc

diff --git a/content/renderer/media/webmediaplayer_ms.cc b/content/renderer/media/webmediaplayer_ms.cc

index a3176ee9a17f1c8cd8142d10b5b816d206dfba41..398cfbe76899a58a16bd3b01922510736a38afbf 100644

--- a/content/renderer/media/webmediaplayer_ms.cc

+++ b/content/renderer/media/webmediaplayer_ms.cc

@@ -248,7 +248,8 @@ void WebMediaPlayerMS::load(LoadType load_type,

if (frame) {

// Report UMA and RAPPOR metrics.

GURL url = source.isURL() ? GURL(source.getAsURL()) : GURL();

- media::ReportMetrics(load_type, url, frame_->getSecurityOrigin());

+ media::ReportMetrics(load_type, url, frame_->getSecurityOrigin(),

+ media_log_);

audio_renderer_ = renderer_factory_->GetAudioRenderer(

web_stream, frame->GetRoutingID(), initial_audio_output_device_id_,