components/flags_ui/feature_entry.cc - Issue 2712513004: Use a qualified path for grit-generated headers in components/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/flags_ui/feature_entry.cc

Issue 2712513004: Use a qualified path for grit-generated headers in components/ (Closed)

Patch Set: more checkdeps Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/error_page/renderer/DEPS ('K') | « components/flags_ui/DEPS ('k') | components/flags_ui/flags_state_unittest.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/flags_ui/feature_entry.h"	5 #include "components/flags_ui/feature_entry.h"

6	6

7 #include "base/logging.h"	7 #include "base/logging.h"

8 #include "base/strings/string_number_conversions.h"	8 #include "base/strings/string_number_conversions.h"

9 #include "base/strings/utf_string_conversions.h"	9 #include "base/strings/utf_string_conversions.h"

10 #include "grit/components_strings.h"	10 #include "components/strings/grit/components_strings.h"

11 #include "ui/base/l10n/l10n_util.h"	11 #include "ui/base/l10n/l10n_util.h"

12	12

13 namespace flags_ui {	13 namespace flags_ui {

14	14

15 std::string FeatureEntry::NameForOption(int index) const {	15 std::string FeatureEntry::NameForOption(int index) const {

16 DCHECK(type == FeatureEntry::MULTI_VALUE \|\|	16 DCHECK(type == FeatureEntry::MULTI_VALUE \|\|

17 type == FeatureEntry::ENABLE_DISABLE_VALUE \|\|	17 type == FeatureEntry::ENABLE_DISABLE_VALUE \|\|

18 type == FeatureEntry::FEATURE_VALUE \|\|	18 type == FeatureEntry::FEATURE_VALUE \|\|

19 type == FeatureEntry::FEATURE_WITH_VARIATIONS_VALUE);	19 type == FeatureEntry::FEATURE_WITH_VARIATIONS_VALUE);

20 DCHECK_LT(index, num_options);	20 DCHECK_LT(index, num_options);

(...skipping 76 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
97	97

98 namespace testing {	98 namespace testing {

99	99

100 // WARNING: '@' is also used in the html file. If you update this constant you	100 // WARNING: '@' is also used in the html file. If you update this constant you

101 // also need to update the html file.	101 // also need to update the html file.

102 const char kMultiSeparator[] = "@";	102 const char kMultiSeparator[] = "@";

103	103

104 } // namespace testing	104 } // namespace testing

105	105

106 } // namespace flags_ui	106 } // namespace flags_ui

OLD	NEW