components/version_info/version_info.cc - Issue 2712513004: Use a qualified path for grit-generated headers in components/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/version_info/version_info.cc

Issue 2712513004: Use a qualified path for grit-generated headers in components/ (Closed)

Patch Set: more checkdeps Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/error_page/renderer/DEPS ('K') | « components/version_info/DEPS ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/version_info/version_info.h"	5 #include "components/version_info/version_info.h"

6	6

7 #include "build/build_config.h"	7 #include "build/build_config.h"

	8 #include "components/strings/grit/components_strings.h"

8 #include "components/version_info/version_info_values.h"	9 #include "components/version_info/version_info_values.h"

9 #include "grit/components_strings.h"

10	10

11 #if defined(USE_UNOFFICIAL_VERSION_NUMBER)	11 #if defined(USE_UNOFFICIAL_VERSION_NUMBER)

12 #include "ui/base/l10n/l10n_util.h" // nogncheck	12 #include "ui/base/l10n/l10n_util.h" // nogncheck

13 #endif // USE_UNOFFICIAL_VERSION_NUMBER	13 #endif // USE_UNOFFICIAL_VERSION_NUMBER

14	14

15 namespace version_info {	15 namespace version_info {

16	16

17 std::string GetProductNameAndVersionForUserAgent() {	17 std::string GetProductNameAndVersionForUserAgent() {

18 return "Chrome/" + GetVersionNumber();	18 return "Chrome/" + GetVersionNumber();

19 }	19 }

(...skipping 74 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
94 current_version += " ";	94 current_version += " ";

95 current_version += GetOSType();	95 current_version += GetOSType();

96 current_version += ")";	96 current_version += ")";

97 #endif // USE_UNOFFICIAL_VERSION_NUMBER	97 #endif // USE_UNOFFICIAL_VERSION_NUMBER

98 if (!modifier.empty())	98 if (!modifier.empty())

99 current_version += " " + modifier;	99 current_version += " " + modifier;

100 return current_version;	100 return current_version;

101 }	101 }

102	102

103 } // namespace version_info	103 } // namespace version_info

OLD	NEW