DEPS: Upgrade snappy to 1.1.4.

DEPS: Upgrade snappy to 1.1.4.

This also switches the snappy mirror reference to the new mirror that
tracks the google/snappy GitHub repository. See http://crbug.com/693936
for details.

BUG=533648
Review-Url: https://codereview.chromium.org/2712273002
Cr-Commit-Position: refs/heads/master@{#456150}
Committed: https://chromium.googlesource.com/chromium/src/+/ca96544ec1b498e802d0028fde5a05220088cba5

[pwnall, 2017-02-26 03:19:12]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-26 03:19:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-02-26 03:30:58]

Laptop benchmarks: (snappy 1.14 is the same / mildly better on most counts,
shows large improvement on decompression)

LevelDB:    version 1.18 (snappy 1.12)
Keys:       16 bytes each
Values:     100 bytes each (50 bytes after compression)
Entries:    1000000
RawSize:    110.6 MB (estimated)
FileSize:   62.9 MB (estimated)
------------------------------------------------
fillseq      :      21.729 micros/op;    5.1 MB/s     
fillsync     :     107.832 micros/op;    1.0 MB/s (1000 ops)
fillrandom   :      22.077 micros/op;    5.0 MB/s     
overwrite    :      22.071 micros/op;    5.0 MB/s     
readrandom   :       7.904 micros/op; (1000000 of 1000000 found)
readrandom   :       7.621 micros/op; (1000000 of 1000000 found)
readseq      :       0.357 micros/op;  310.2 MB/s    
readreverse  :       0.573 micros/op;  193.0 MB/s    
compact      :  529167.000 micros/op;
readrandom   :       6.011 micros/op; (1000000 of 1000000 found)
readseq      :       0.321 micros/op;  344.8 MB/s    
readreverse  :       0.512 micros/op;  215.9 MB/s    
fill100K     :     636.614 micros/op;  149.8 MB/s (1000 ops)
crc32c       :       4.199 micros/op;  930.2 MB/s (4K per op)
snappycomp   :       4.767 micros/op;  819.5 MB/s (output: 55.1%)
snappyuncomp :       1.066 micros/op; 3663.4 MB/s    
acquireload  :       0.198 micros/op; (each op is 1000 loads)

LevelDB:    version 1.18 (snappy 1.14)
Keys:       16 bytes each
Values:     100 bytes each (50 bytes after compression)
Entries:    1000000
RawSize:    110.6 MB (estimated)
FileSize:   62.9 MB (estimated)
------------------------------------------------
fillseq      :      21.881 micros/op;    5.1 MB/s     
fillsync     :     108.386 micros/op;    1.0 MB/s (1000 ops)
fillrandom   :      21.999 micros/op;    5.0 MB/s     
overwrite    :      21.962 micros/op;    5.0 MB/s     
readrandom   :       7.697 micros/op; (1000000 of 1000000 found)
readrandom   :       7.369 micros/op; (1000000 of 1000000 found)
readseq      :       0.358 micros/op;  308.8 MB/s    
readreverse  :       0.634 micros/op;  174.4 MB/s    
compact      :  527426.000 micros/op;
readrandom   :       5.950 micros/op; (1000000 of 1000000 found)
readseq      :       0.318 micros/op;  348.2 MB/s    
readreverse  :       0.509 micros/op;  217.5 MB/s    
fill100K     :     657.257 micros/op;  145.1 MB/s (1000 ops)
crc32c       :       4.053 micros/op;  963.7 MB/s (4K per op)
snappycomp   :       4.936 micros/op;  791.4 MB/s (output: 55.1%)
snappyuncomp :       0.864 micros/op; 4520.8 MB/s    
acquireload  :       0.219 micros/op; (each op is 1000 loads)

[commit-bot: I haz the power, 2017-02-26 03:33:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-26 03:33:24]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[pwnall, 2017-03-08 20:36:51]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 20:37:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-03-08 20:41:35]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 20:42:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 21:41:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 21:41:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pwnall, 2017-03-09 01:13:41]

pwnall@chromium.org changed reviewers:
+ jsbell@chromium.org

[pwnall, 2017-03-09 01:13:42]

PTAL?

In case you're wondering, the linux_chromium_chromeos_ozone_rel_ng build seems
to fail for other CLs in the same way.
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

[pwnall, 2017-03-09 22:45:33]

On 2017/03/09 01:13:42, pwnall wrote:
> PTAL?
> 
> In case you're wondering, the linux_chromium_chromeos_ozone_rel_ng build seems
> to fail for other CLs in the same way.
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

The bot is healthy now and tests passed :D PTAL?

[jsbell, 2017-03-09 23:08:22]

https://codereview.chromium.org/2712273002/diff/40001/third_party/snappy/READ...
File third_party/snappy/README.chromium (left):

https://codereview.chromium.org/2712273002/diff/40001/third_party/snappy/READ...
third_party/snappy/README.chromium:13: * #ifndef DISALLOW_COPY_AND_ASSIGN -
https://github.com/google/snappy/pull/21
If this is gone, I'd expect the #ifndefs to be removed, i.e. this CL to be
reverted:

https://codereview.chromium.org/1997503005

[pwnall, 2017-03-10 00:38:35]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 00:38:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-03-10 02:45:52]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[pwnall, 2017-03-10 02:46:07]

Patchset #4 (id:60001) has been deleted

[pwnall, 2017-03-10 02:46:13]

Patchset #4 (id:80001) has been deleted

[pwnall, 2017-03-10 02:46:21]

Patchset #4 (id:100001) has been deleted

[commit-bot: I haz the power, 2017-03-10 02:46:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-03-10 03:03:51]

PTAL?

https://codereview.chromium.org/2712273002/diff/40001/third_party/snappy/READ...
File third_party/snappy/README.chromium (left):

https://codereview.chromium.org/2712273002/diff/40001/third_party/snappy/READ...
third_party/snappy/README.chromium:13: * #ifndef DISALLOW_COPY_AND_ASSIGN -
https://github.com/google/snappy/pull/21
On 2017/03/09 23:08:22, jsbell wrote:
> If this is gone, I'd expect the #ifndefs to be removed, i.e. this CL to be
> reverted:
> 
> https://codereview.chromium.org/1997503005

Ack.

The PR referenced there was accepted into snappy, so the conditional define is
still there. It's just not a local change anymore.

That being said, I was completely unaware about having to regenerate the
configuration files. I have done so, and tweaked the results so things compile.

[commit-bot: I haz the power, 2017-03-10 04:34:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 04:34:01]

Dry run: This issue passed the CQ dry run.

[pwnall, 2017-03-10 08:10:59]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 08:11:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 09:28:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 09:28:32]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[jsbell, 2017-03-10 15:57:36]

lgtm apart from build fix needed

https://codereview.chromium.org/2712273002/diff/140001/third_party/snappy/BUI...
File third_party/snappy/BUILD.gn (right):

https://codereview.chromium.org/2712273002/diff/140001/third_party/snappy/BUI...
third_party/snappy/BUILD.gn:29: cflags = [ "/wd4018" ]  # Signed/unsigned
mismatch in comparison.
+= ?

https://codereview.chromium.org/2712273002/diff/140001/third_party/snappy/win...
File third_party/snappy/win32/config.h (right):

https://codereview.chromium.org/2712273002/diff/140001/third_party/snappy/win...
third_party/snappy/win32/config.h:1: 
Did it really generate this blank line?

[pwnall, 2017-03-10 17:48:46]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 17:49:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-03-10 18:03:11]

Thank you very much for your feedback!

https://codereview.chromium.org/2712273002/diff/140001/third_party/snappy/BUI...
File third_party/snappy/BUILD.gn (right):

https://codereview.chromium.org/2712273002/diff/140001/third_party/snappy/BUI...
third_party/snappy/BUILD.gn:29: cflags = [ "/wd4018" ]  # Signed/unsigned
mismatch in comparison.
On 2017/03/10 15:57:36, jsbell wrote:
> += ?

Done!
Thank you! Durr durr

https://codereview.chromium.org/2712273002/diff/140001/third_party/snappy/win...
File third_party/snappy/win32/config.h (right):

https://codereview.chromium.org/2712273002/diff/140001/third_party/snappy/win...
third_party/snappy/win32/config.h:1: 
On 2017/03/10 15:57:36, jsbell wrote:
> Did it really generate this blank line?

Done.
No, that was my editor :(

Thank you very much for catching this!

[commit-bot: I haz the power, 2017-03-10 18:15:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 18:15:48]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pwnall, 2017-03-10 19:28:46]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 19:29:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 20:31:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 20:31:08]

Dry run: This issue passed the CQ dry run.

[pwnall, 2017-03-10 20:31:56]

The CQ bit was checked by pwnall@chromium.org

[pwnall, 2017-03-10 20:31:56]

The patchset sent to the CQ was uploaded after l-g-t-m from jsbell@chromium.org
Link to the patchset: https://codereview.chromium.org/2712273002/#ps180001
(title: "Buildbot fix, take 2.")

[commit-bot: I haz the power, 2017-03-10 20:32:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 20:37:56]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1489177916435100,
"parent_rev": "29d0ee0571a18cb30818f2c4288118e0a57142e7", "commit_rev":
"ca96544ec1b498e802d0028fde5a05220088cba5"}

[commit-bot: I haz the power, 2017-03-10 20:38:37]

Description was changed from

==========
DEPS: Upgrade snappy to 1.1.4.

This also switches the snappy mirror reference to the new mirror that
tracks the google/snappy GitHub repository. See http://crbug.com/693936
for details.

BUG=533648
==========

to

==========
DEPS: Upgrade snappy to 1.1.4.

This also switches the snappy mirror reference to the new mirror that
tracks the google/snappy GitHub repository. See http://crbug.com/693936
for details.

BUG=533648

Review-Url: https://codereview.chromium.org/2712273002
Cr-Commit-Position: refs/heads/master@{#456150}
Committed:
https://chromium.googlesource.com/chromium/src/+/ca96544ec1b498e802d0028fde5a...
==========

[commit-bot: I haz the power, 2017-03-10 20:38:38]

Committed patchset #7 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/ca96544ec1b498e802d0028fde5a...