third_party/snappy/README.chromium - Issue 2712273002: DEPS: Upgrade snappy to 1.1.4.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/snappy/README.chromium

Issue 2712273002: DEPS: Upgrade snappy to 1.1.4. (Closed)

Patch Set: Update README.chromium to reflect version change. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Name: Snappy: A fast compressor/decompressor	1 Name: Snappy: A fast compressor/decompressor

2 Short Name: snappy	2 Short Name: snappy

3 URL: http://google.github.io/snappy/	3 URL: http://google.github.io/snappy/

4 Version: 1.1.0-updates	4 Version: 1.1.4-head

5 License: New BSD	5 License: New BSD

6 License File: src/COPYING	6 License File: src/COPYING

7 Security Critical: yes	7 Security Critical: yes

8	8

9 Description:	9 Description:

10 Compression library used by LevelDB.	10 Compression library used by LevelDB.

11	11

12 Local Changes:

13 * #ifndef DISALLOW_COPY_AND_ASSIGN - https://github.com/google/snappy/pull/21
jsbell 2017/03/09 23:08:22 If this is gone, I'd expect the #ifndefs to be rem If this is gone, I'd expect the #ifndefs to be removed, i.e. this CL to be reverted: https://codereview.chromium.org/1997503005 pwnall 2017/03/10 03:03:51 Ack. The PR referenced there was accepted into sn Show quoted text On 2017/03/09 23:08:22, jsbell wrote: > If this is gone, I'd expect the #ifndefs to be removed, i.e. this CL to be > reverted: > > https://codereview.chromium.org/1997503005 Ack. The PR referenced there was accepted into snappy, so the conditional define is still there. It's just not a local change anymore. That being said, I was completely unaware about having to regenerate the configuration files. I have done so, and tweaked the results so things compile.
14

15 Local Additions:	12 Local Additions:

16 * gyp file for building in chromium	13 * gyp file for building in chromium

17 * Suppress clang header-hygiene warning - https://code.google.com/p/snappy/iss ues/detail?id=70	14 * Suppress clang header-hygiene warning - https://code.google.com/p/snappy/iss ues/detail?id=70

18 * Suppress MSVC signed/unsigned warning - https://code.google.com/p/snappy/iss ues/detail?id=71	15 * Suppress MSVC signed/unsigned warning - https://code.google.com/p/snappy/iss ues/detail?id=71

19 * Suppress MSVC x64 size_t warnings - https://code.google.com/p/snappy/issues/ detail?id=75	16 * Suppress MSVC x64 size_t warnings - https://code.google.com/p/snappy/issues/ detail?id=75

20 * {mac,linux,win32}/snappy-stubs-public.h autogenerated public headers	17 * {mac,linux,win32}/snappy-stubs-public.h autogenerated public headers

OLD	NEW

« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »