ifdef Snappy's version of DISALLOW_COPY_AND_ASSIGN.

ifdef Snappy's version of DISALLOW_COPY_AND_ASSIGN.

This avoids macro redefinition errors if we change Chromium's definition of this
macro to use "= delete".

Upstream rejected changing this macro in the same way because they want to stay
C++98-only, but agreed to accept this change (though as of right now that hasn't
actually happened yet).

BUG=447156
TEST=none

Committed: https://crrev.com/9ce70473fc0976e9916749a5f69dcabfea0f40c0
Cr-Commit-Position: refs/heads/master@{#394913}

[Peter Kasting, 2016-05-19 05:45:29]

pkasting@chromium.org changed reviewers:
+ jsbell@chromium.org

[jsbell, 2016-05-19 17:04:50]

lgtm

[cmumford, 2016-05-19 17:13:36]

cmumford@chromium.org changed reviewers:
+ cmumford@chromium.org

[cmumford, 2016-05-19 17:13:37]

https://codereview.chromium.org/1997503005/diff/1/third_party/snappy/README.c...
File third_party/snappy/README.chromium (right):

https://codereview.chromium.org/1997503005/diff/1/third_party/snappy/README.c...
third_party/snappy/README.chromium:13: * #ifdef DISALLOW_COPY_AND_ASSIGN -
https://github.com/google/snappy/pull/21
ifndef ?

[Peter Kasting, 2016-05-19 18:09:32]

https://codereview.chromium.org/1997503005/diff/1/third_party/snappy/README.c...
File third_party/snappy/README.chromium (right):

https://codereview.chromium.org/1997503005/diff/1/third_party/snappy/README.c...
third_party/snappy/README.chromium:13: * #ifdef DISALLOW_COPY_AND_ASSIGN -
https://github.com/google/snappy/pull/21
On 2016/05/19 17:13:37, cmumford wrote:
> ifndef ?

I guess?  I basically meant "put DISALLOW_COPY_AND_ASSIGN under preprocessor
control", I used "#ifdef" generically as a euphemism for "preprocessor".

I'll change it.

[Peter Kasting, 2016-05-19 21:57:30]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2016-05-19 21:57:30]

The patchset sent to the CQ was uploaded after l-g-t-m from jsbell@chromium.org
Link to the patchset: https://codereview.chromium.org/1997503005/#ps20001
(title: "Review comment")

[commit-bot: I haz the power, 2016-05-19 21:58:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1997503005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1997503005/20001

[commit-bot: I haz the power, 2016-05-20 00:04:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-20 00:07:20]

Description was changed from

==========
ifdef Snappy's version of DISALLOW_COPY_AND_ASSIGN.

This avoids macro redefinition errors if we change Chromium's definition of this
macro to use "= delete".

Upstream rejected changing this macro in the same way because they want to stay
C++98-only, but agreed to accept this change (though as of right now that hasn't
actually happened yet).

BUG=447156
TEST=none
==========

to

==========
ifdef Snappy's version of DISALLOW_COPY_AND_ASSIGN.

This avoids macro redefinition errors if we change Chromium's definition of this
macro to use "= delete".

Upstream rejected changing this macro in the same way because they want to stay
C++98-only, but agreed to accept this change (though as of right now that hasn't
actually happened yet).

BUG=447156
TEST=none

Committed: https://crrev.com/9ce70473fc0976e9916749a5f69dcabfea0f40c0
Cr-Commit-Position: refs/heads/master@{#394913}
==========

[commit-bot: I haz the power, 2016-05-20 00:07:21]

Patchset 2 (id:??) landed as
https://crrev.com/9ce70473fc0976e9916749a5f69dcabfea0f40c0
Cr-Commit-Position: refs/heads/master@{#394913}