Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2712033004: cc: Always log shader compiler errors (Closed)

Created:
3 years, 10 months ago by ccameron
Modified:
3 years, 10 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Always log shader compiler errors This is a catastrophic error, and should spam the console. BUG=695431 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2712033004 Cr-Commit-Position: refs/heads/master@{#453019} Committed: https://chromium.googlesource.com/chromium/src/+/7d39070d75082cd35a08775dd792d67cd2beeb40

Patch Set 1 #

Patch Set 2 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M cc/output/program_binding.h View 1 3 chunks +8 lines, -5 lines 0 comments Download
M cc/output/program_binding.cc View 1 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ccameron
This is to hopefully get some debug information about why shader compile is failing on ...
3 years, 10 months ago (2017-02-24 20:53:55 UTC) #3
enne (OOO)
lgtm
3 years, 10 months ago (2017-02-24 20:57:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712033004/20001
3 years, 10 months ago (2017-02-24 21:07:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7d39070d75082cd35a08775dd792d67cd2beeb40
3 years, 10 months ago (2017-02-25 00:41:20 UTC) #9
ccameron
3 years, 8 months ago (2017-04-06 20:46:55 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2799743005/ by ccameron@chromium.org.

The reason for reverting is: Causes performance regression
BUG=699743.

Powered by Google App Engine
This is Rietveld 408576698