Remove DumpWithoutCrashing() from sync/engine/commit_util

Remove DumpWithoutCrashing() from sync/engine/commit_util

This looks to be out of date code (related bug marked Fixed in 2015).
Part of trying to rationalize all calls to DumpWithoutCrashing() as they
can obscure real crashes due to upload throttling.

R=stanisc@chromium.org
BUG=332371, 694688
Review-Url: https://codereview.chromium.org/2712013002
Cr-Commit-Position: refs/heads/master@{#452678}
Committed: https://chromium.googlesource.com/chromium/src/+/bdfe69d301b8826665a213a553647e26f3b198c1

[scottmg, 2017-02-23 22:46:08]

Description was changed from

==========
Remove DumpWithoutCrashing() from sync/engine/commit_util

This looks to be out of date code (related bug marked Fixed in 2015).
Part of trying to rationalize all calls to DumpWithoutCrashing() as they
can obscure real crashes due to upload throttling.

R=gangwu@chromium.org
BUG=332371, 694688
==========

to

==========
Remove DumpWithoutCrashing() from sync/engine/commit_util

This looks to be out of date code (related bug marked Fixed in 2015).
Part of trying to rationalize all calls to DumpWithoutCrashing() as they
can obscure real crashes due to upload throttling.

R=stanisc@chromium.org
BUG=332371, 694688
==========

[scottmg, 2017-02-23 22:46:08]

scottmg@chromium.org changed reviewers:
+ stanisc@chromium.org
- gangwu@chromium.org

[scottmg, 2017-02-23 22:46:23]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 22:47:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stanisc, 2017-02-23 23:26:29]

lgtm

[scottmg, 2017-02-23 23:27:45]

The CQ bit was unchecked by scottmg@chromium.org

[scottmg, 2017-02-23 23:27:49]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2017-02-23 23:28:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 23:53:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487892469539810, "parent_rev":
"b998a332e36c9bfa2dc92bd66d56a791e4c06d20", "commit_rev":
"bdfe69d301b8826665a213a553647e26f3b198c1"}

[commit-bot: I haz the power, 2017-02-23 23:54:03]

Description was changed from

==========
Remove DumpWithoutCrashing() from sync/engine/commit_util

This looks to be out of date code (related bug marked Fixed in 2015).
Part of trying to rationalize all calls to DumpWithoutCrashing() as they
can obscure real crashes due to upload throttling.

R=stanisc@chromium.org
BUG=332371, 694688
==========

to

==========
Remove DumpWithoutCrashing() from sync/engine/commit_util

This looks to be out of date code (related bug marked Fixed in 2015).
Part of trying to rationalize all calls to DumpWithoutCrashing() as they
can obscure real crashes due to upload throttling.

R=stanisc@chromium.org
BUG=332371, 694688

Review-Url: https://codereview.chromium.org/2712013002
Cr-Commit-Position: refs/heads/master@{#452678}
Committed:
https://chromium.googlesource.com/chromium/src/+/bdfe69d301b8826665a213a55364...
==========

[commit-bot: I haz the power, 2017-02-23 23:54:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bdfe69d301b8826665a213a55364...