Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: components/sync/engine_impl/commit_util.cc

Issue 2712013002: Remove DumpWithoutCrashing() from sync/engine/commit_util (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/engine_impl/commit_util.cc
diff --git a/components/sync/engine_impl/commit_util.cc b/components/sync/engine_impl/commit_util.cc
index c8ddfc96661e8e2c7efeee119f92385810af3900..ccb6200883ab403fa48ad86988a4666cb760c56b 100644
--- a/components/sync/engine_impl/commit_util.cc
+++ b/components/sync/engine_impl/commit_util.cc
@@ -8,7 +8,6 @@
#include <string>
#include <vector>
-#include "base/debug/dump_without_crashing.h"
#include "base/strings/string_util.h"
#include "components/sync/base/attachment_id_proto.h"
#include "components/sync/base/time.h"
@@ -177,10 +176,6 @@ void BuildCommitItem(const syncable::Entry& meta_entry,
meta_entry.GetUniquePosition().ToInt64());
meta_entry.GetUniquePosition().ToProto(
sync_entry->mutable_unique_position());
- if (!meta_entry.GetUniquePosition().IsValid()) {
- // Should never upload invalid unique position for bookmark to server.
- base::debug::DumpWithoutCrashing();
- }
}
// Always send specifics for bookmarks.
SetEntrySpecifics(meta_entry, sync_entry);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698