Remove DumpWithoutCrashing() from sync/engine/commit_util

components/sync/engine_impl/commit_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync/engine_impl/commit_util.h"
 
 #include <limits>
 #include <string>
 #include <vector>
 
-#include "base/debug/dump_without_crashing.h"
 #include "base/strings/string_util.h"
 #include "components/sync/base/attachment_id_proto.h"
 #include "components/sync/base/time.h"
 #include "components/sync/base/unique_position.h"
 #include "components/sync/engine_impl/syncer_proto_util.h"
 #include "components/sync/protocol/bookmark_specifics.pb.h"
 #include "components/sync/syncable/directory.h"
 #include "components/sync/syncable/entry.h"
 #include "components/sync/syncable/model_neutral_mutable_entry.h"
 #include "components/sync/syncable/syncable_base_transaction.h"
@@ skipping 148 matching lines @@
       // Both insert_after_item_id and position_in_parent fields are set only
       // for legacy reasons.  See comments in sync.proto for more information.
       const Id& prev_id = meta_entry.GetPredecessorId();
       string prev_id_string =
           prev_id.IsNull() ? string() : prev_id.GetServerId();
       sync_entry->set_insert_after_item_id(prev_id_string);
       sync_entry->set_position_in_parent(
           meta_entry.GetUniquePosition().ToInt64());
       meta_entry.GetUniquePosition().ToProto(
           sync_entry->mutable_unique_position());
-      if (!meta_entry.GetUniquePosition().IsValid()) {
-        // Should never upload invalid unique position for bookmark to server.
-        base::debug::DumpWithoutCrashing();
-      }
     }
     // Always send specifics for bookmarks.
     SetEntrySpecifics(meta_entry, sync_entry);
     return;
   }
 
   // Deletion is final on the server, let's move things and then delete them.
   if (meta_entry.GetIsDel()) {
     sync_entry->set_deleted(true);
 
@@ skipping 252 matching lines @@
 
   ProcessSuccessfulCommitResponse(commit_request_entry, server_entry,
                                   local_entry.GetId(), &local_entry,
                                   dirty_sync_was_set, deleted_folders);
   return response;
 }
 
 }  // namespace commit_util
 
 }  // namespace syncer