Links in generation prompts should go to passwords.google.com.

Links in generation prompts should go to passwords.google.com.

Screenshots for more context are on the bug https://bugs.chromium.org/p/chromium/issues/detail?id=695468#c1

This CL covers all Desktop except Mac, Mac implementation will be in separate CL.

BUG=695468
Review-Url: https://codereview.chromium.org/2711563006
Cr-Commit-Position: refs/heads/master@{#453180}
Committed: https://chromium.googlesource.com/chromium/src/+/99d21fffc7976a075b6351db541b203c750926cb

[dvadym, 2017-02-23 15:39:39]

Description was changed from

==========
Link in generation prompts should go to passwords.google.com

BUG=695468
==========

to

==========
Links in generation prompts should go to passwords.google.com

BUG=695468
==========

[dvadym, 2017-02-23 15:53:36]

Description was changed from

==========
Links in generation prompts should go to passwords.google.com

BUG=695468
==========

to

==========
Links in generation prompts should go to passwords.google.com.

Screenshots for more context are on the bug
https://bugs.chromium.org/p/chromium/issues/detail?id=695468#c1

BUG=695468
==========

[dvadym, 2017-02-23 15:55:55]

dvadym@chromium.org changed reviewers:
+ vasilii@chromium.org

[dvadym, 2017-02-23 15:55:56]

Hi Vasilii,

 Could you please review chrome/browser/ui/passwords/* ?

Regards,
Vadym

[dvadym, 2017-02-23 15:57:52]

dvadym@chromium.org changed reviewers:
+ mathp@chromium.org

[dvadym, 2017-02-23 15:57:53]

Hi Mathieu,

 could you please review
chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc ?

Regards,
Vadym

[vasilii, 2017-02-24 14:50:09]

What about the non-syncing users who turned the feature on in the settings?

[dvadym, 2017-02-24 14:53:37]

The setting was not approved by UX :(

[dvadym, 2017-02-24 14:54:04]

dvadym@chromium.org changed reviewers:
- mathp@chromium.org

[vasilii, 2017-02-24 15:03:25]

https://codereview.chromium.org/2711563006/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc (right):

https://codereview.chromium.org/2711563006/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc:520:
parent_->model()->OnNavigateToPasswordManagerAccountDashboardLinkClicked();
Forgot about Cocoa?

https://codereview.chromium.org/2711563006/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2711563006/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:102629: +  <int value="12"
label="Clicked link passwords.google.com"/>
the link to

[dvadym, 2017-02-24 15:51:33]

Description was changed from

==========
Links in generation prompts should go to passwords.google.com.

Screenshots for more context are on the bug
https://bugs.chromium.org/p/chromium/issues/detail?id=695468#c1

BUG=695468
==========

to

==========
Links in generation prompts should go to passwords.google.com.

Screenshots for more context are on the bug
https://bugs.chromium.org/p/chromium/issues/detail?id=695468#c1

This CL covers all Desktop except Mac, Mac implementation will be in separate
CL.

BUG=695468
==========

[dvadym, 2017-02-24 15:55:34]

https://codereview.chromium.org/2711563006/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc (right):

https://codereview.chromium.org/2711563006/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc:520:
parent_->model()->OnNavigateToPasswordManagerAccountDashboardLinkClicked();
On 2017/02/24 15:03:25, vasilii wrote:
> Forgot about Cocoa?

I'll do Mac in a separate CL. I've updated CL description to show this.

https://codereview.chromium.org/2711563006/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2711563006/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:102629: +  <int value="12"
label="Clicked link passwords.google.com"/>
On 2017/02/24 15:03:25, vasilii wrote:
> the link to

Done.

[vasilii, 2017-02-24 16:04:36]

chrome/browser/ui LGTM

https://codereview.chromium.org/2711563006/diff/100001/chrome/browser/ui/auto...
File chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
(right):

https://codereview.chromium.org/2711563006/diff/100001/chrome/browser/ui/auto...
chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc:234:
chrome::Navigate(&params);
Not sure why it's different for Android.

[dvadym, 2017-02-24 16:08:00]

Thanks for review Vasilii!

https://codereview.chromium.org/2711563006/diff/100001/chrome/browser/ui/auto...
File chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
(right):

https://codereview.chromium.org/2711563006/diff/100001/chrome/browser/ui/auto...
chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc:234:
chrome::Navigate(&params);
On 2017/02/24 16:04:36, vasilii wrote:
> Not sure why it's different for Android.

Good point. I don't have mocks for Android for now. And since Desktop are going
to be launched first, I want to make everything works for Desktop.

[dvadym, 2017-02-24 16:09:05]

dvadym@chromium.org changed reviewers:
+ isherman@chromium.org

[dvadym, 2017-02-24 16:09:06]

Hi Ilya,

 could you please review histograms.xml?

Regards,
Vadym

[Ilya Sherman, 2017-02-24 21:55:10]

histograms.xml lgtm

[dvadym, 2017-02-27 09:34:43]

The CQ bit was checked by dvadym@chromium.org

[commit-bot: I haz the power, 2017-02-27 09:35:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 10:30:37]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488188083093210,
"parent_rev": "f65878729393c484e6a25ea8a91394d7f5d11e10", "commit_rev":
"99d21fffc7976a075b6351db541b203c750926cb"}

[commit-bot: I haz the power, 2017-02-27 10:31:14]

Description was changed from

==========
Links in generation prompts should go to passwords.google.com.

Screenshots for more context are on the bug
https://bugs.chromium.org/p/chromium/issues/detail?id=695468#c1

This CL covers all Desktop except Mac, Mac implementation will be in separate
CL.

BUG=695468
==========

to

==========
Links in generation prompts should go to passwords.google.com.

Screenshots for more context are on the bug
https://bugs.chromium.org/p/chromium/issues/detail?id=695468#c1

This CL covers all Desktop except Mac, Mac implementation will be in separate
CL.

BUG=695468

Review-Url: https://codereview.chromium.org/2711563006
Cr-Commit-Position: refs/heads/master@{#453180}
Committed:
https://chromium.googlesource.com/chromium/src/+/99d21fffc7976a075b6351db541b...
==========

[commit-bot: I haz the power, 2017-02-27 10:31:16]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/99d21fffc7976a075b6351db541b...