Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Side by Side Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 2711563006: Links in generation prompts should go to passwords.google.com. (Closed)
Patch Set: Added a method in mock Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h" 5 #include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "base/timer/timer.h" 9 #include "base/timer/timer.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
510 } 510 }
511 511
512 ManagePasswordsBubbleView::SaveConfirmationView::~SaveConfirmationView() { 512 ManagePasswordsBubbleView::SaveConfirmationView::~SaveConfirmationView() {
513 } 513 }
514 514
515 void ManagePasswordsBubbleView::SaveConfirmationView::StyledLabelLinkClicked( 515 void ManagePasswordsBubbleView::SaveConfirmationView::StyledLabelLinkClicked(
516 views::StyledLabel* label, 516 views::StyledLabel* label,
517 const gfx::Range& range, 517 const gfx::Range& range,
518 int event_flags) { 518 int event_flags) {
519 DCHECK_EQ(range, parent_->model()->save_confirmation_link_range()); 519 DCHECK_EQ(range, parent_->model()->save_confirmation_link_range());
520 parent_->model()->OnManageLinkClicked(); 520 parent_->model()->OnNavigateToPasswordManagerAccountDashboardLinkClicked();
vasilii 2017/02/24 15:03:25 Forgot about Cocoa?
dvadym 2017/02/24 15:55:34 I'll do Mac in a separate CL. I've updated CL desc
521 parent_->CloseBubble(); 521 parent_->CloseBubble();
522 } 522 }
523 523
524 void ManagePasswordsBubbleView::SaveConfirmationView::ButtonPressed( 524 void ManagePasswordsBubbleView::SaveConfirmationView::ButtonPressed(
525 views::Button* sender, const ui::Event& event) { 525 views::Button* sender, const ui::Event& event) {
526 DCHECK_EQ(sender, ok_button_); 526 DCHECK_EQ(sender, ok_button_);
527 parent_->model()->OnOKClicked(); 527 parent_->model()->OnOKClicked();
528 parent_->CloseBubble(); 528 parent_->CloseBubble();
529 } 529 }
530 530
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
831 } else if (model_.state() == 831 } else if (model_.state() ==
832 password_manager::ui::CHROME_DESKTOP_IOS_PROMO_STATE) { 832 password_manager::ui::CHROME_DESKTOP_IOS_PROMO_STATE) {
833 AddChildView(new DesktopIOSPromotionBubbleView( 833 AddChildView(new DesktopIOSPromotionBubbleView(
834 model_.GetProfile(), 834 model_.GetProfile(),
835 desktop_ios_promotion::PromotionEntryPoint::SAVE_PASSWORD_BUBBLE)); 835 desktop_ios_promotion::PromotionEntryPoint::SAVE_PASSWORD_BUBBLE));
836 #endif 836 #endif
837 } else { 837 } else {
838 AddChildView(new ManageView(this)); 838 AddChildView(new ManageView(this));
839 } 839 }
840 } 840 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698