Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4560)

Unified Diff: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

Issue 2711563006: Links in generation prompts should go to passwords.google.com. (Closed)
Patch Set: histograms.xml fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_bubble_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
index 524f0165a2b339c9903184a85cd0e6b8d961755a..ebca9f2ccfe00edda2c12b0549b82d316eea36f0 100644
--- a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
+++ b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
@@ -16,7 +16,7 @@
#include "chrome/browser/ui/autofill/password_generation_popup_view.h"
#include "chrome/browser/ui/autofill/popup_constants.h"
#include "chrome/browser/ui/browser_finder.h"
-#include "chrome/browser/ui/chrome_pages.h"
+#include "chrome/browser/ui/browser_navigator_params.h"
#include "chrome/common/url_constants.h"
#include "chrome/grit/chromium_strings.h"
#include "chrome/grit/generated_resources.h"
@@ -24,6 +24,7 @@
#include "components/autofill/core/browser/suggestion.h"
#include "components/password_manager/core/browser/password_bubble_experiment.h"
#include "components/password_manager/core/browser/password_manager.h"
+#include "components/password_manager/core/browser/password_manager_constants.h"
#include "content/public/browser/native_web_keyboard_event.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
@@ -225,9 +226,12 @@ void PasswordGenerationPopupControllerImpl::OnSavedPasswordsLinkClicked() {
#if defined(OS_ANDROID)
chrome::android::ChromeApplication::ShowPasswordSettings();
#else
- chrome::ShowSettingsSubPage(
- chrome::FindBrowserWithWebContents(controller_common_.web_contents()),
- chrome::kPasswordManagerSubPage);
+ chrome::NavigateParams params(
+ chrome::FindBrowserWithWebContents(web_contents()),
+ GURL(password_manager::kPasswordManagerAccountDashboardURL),
+ ui::PAGE_TRANSITION_LINK);
+ params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
+ chrome::Navigate(&params);
vasilii 2017/02/24 16:04:36 Not sure why it's different for Android.
dvadym 2017/02/24 16:08:00 Good point. I don't have mocks for Android for now
#endif
}
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_bubble_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698