Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2711533002:
Revert of Add DumpWithoutCrashing in RendererDidNavigateToExistingPage (Closed)
DescriptionRevert of Add DumpWithoutCrashing in RendererDidNavigateToExistingPage (patchset #3 id:40001 of https://codereview.chromium.org/2701523004/ )
Reason for revert:
We got the data we wanted.
Original issue's description:
> Add DumpWithoutCrashing in RendererDidNavigateToExistingPage
>
> This is intended to be reverted after investigating the linked bug.
>
> BUG=688425
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Review-Url: https://codereview.chromium.org/2701523004
> Cr-Commit-Position: refs/heads/master@{#450900}
> Committed: https://chromium.googlesource.com/chromium/src/+/c32cd2069ae8062b52e5b7b1faf5936bd71a583a
TBR=nasko@chromium.org,estark@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=688425
Review-Url: https://codereview.chromium.org/2711533002
Cr-Commit-Position: refs/heads/master@{#451960}
Committed: https://chromium.googlesource.com/chromium/src/+/c5608a34fd0112511e9165179a91cdd9277518b2
Patch Set 1 #
Messages
Total messages: 24 (13 generated)
The CQ bit was checked by jam@chromium.org
Created Revert of Add DumpWithoutCrashing in RendererDidNavigateToExistingPage
lgtm
The CQ bit was unchecked by jam@chromium.org
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jam@chromium.org
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487741887722790, "parent_rev":
"a68600309d39180eda0c6f30be56058dabe2d8c8", "commit_rev":
"c5608a34fd0112511e9165179a91cdd9277518b2"}
Message was sent while issue was closed.
Description was changed from ========== Revert of Add DumpWithoutCrashing in RendererDidNavigateToExistingPage (patchset #3 id:40001 of https://codereview.chromium.org/2701523004/ ) Reason for revert: We got the data we wanted. Original issue's description: > Add DumpWithoutCrashing in RendererDidNavigateToExistingPage > > This is intended to be reverted after investigating the linked bug. > > BUG=688425 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2701523004 > Cr-Commit-Position: refs/heads/master@{#450900} > Committed: https://chromium.googlesource.com/chromium/src/+/c32cd2069ae8062b52e5b7b1faf5... TBR=nasko@chromium.org,estark@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=688425 ========== to ========== Revert of Add DumpWithoutCrashing in RendererDidNavigateToExistingPage (patchset #3 id:40001 of https://codereview.chromium.org/2701523004/ ) Reason for revert: We got the data we wanted. Original issue's description: > Add DumpWithoutCrashing in RendererDidNavigateToExistingPage > > This is intended to be reverted after investigating the linked bug. > > BUG=688425 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2701523004 > Cr-Commit-Position: refs/heads/master@{#450900} > Committed: https://chromium.googlesource.com/chromium/src/+/c32cd2069ae8062b52e5b7b1faf5... TBR=nasko@chromium.org,estark@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=688425 Review-Url: https://codereview.chromium.org/2711533002 Cr-Commit-Position: refs/heads/master@{#451960} Committed: https://chromium.googlesource.com/chromium/src/+/c5608a34fd0112511e9165179a91... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c5608a34fd0112511e9165179a91... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
