Revert of Add DumpWithoutCrashing in RendererDidNavigateToExistingPage

content/browser/frame_host/navigation_controller_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  *     (http://www.torchmobile.com/)
  *
@@ skipping 21 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "content/browser/frame_host/navigation_controller_impl.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
-#include "base/debug/alias.h"
 #include "base/debug/dump_without_crashing.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_number_conversions.h"  // Temporary
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "base/trace_event/trace_event.h"
 #include "build/build_config.h"
@@ skipping 105 matching lines @@
     return true;
   }
 
   if (ui::PageTransitionCoreTypeIs(entry->GetTransitionType(),
                                    ui::PAGE_TRANSITION_LINK)) {
     return true;
   }
   return false;
 }
 
-// TODO(estark): remove this DumpWithoutCrashing after investigating
-// https://crbug.com/688425.
-void MaybeDumpCopiedNonSameOriginEntry(
-    const std::string& navigation_description,
-    const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
-    bool is_in_page,
-    NavigationEntry* entry) {
-  if (!entry)
-    return;
-  if (url::Origin(entry->GetURL()).IsSameOriginWith(url::Origin(params.url)))
-    return;
-
-  std::string debug_info =
-      navigation_description + ": " +
-      std::string(is_in_page ? "Is in page, " : "Is not in page, ") +
-      std::string(params.nav_entry_id ? "has nav entry id, "
-                                      : "does not have nav entry id, ") +
-      std::string(params.did_create_new_entry ? "did create new entry, "
-                                              : "did not create new entry, ") +
-      std::string(params.should_replace_current_entry
-                      ? "should replace current entry, "
-                      : "should not replace current entry, ") +
-      entry->GetURL().spec() + " -> " + params.url.spec();
-  char debug_buf[2000];
-  base::strlcpy(debug_buf, debug_info.c_str(), arraysize(debug_buf));
-  base::debug::Alias(&debug_buf);
-  base::debug::DumpWithoutCrashing();
-}
-
 }  // namespace
 
 // NavigationControllerImpl ----------------------------------------------------
 
 const size_t kMaxEntryCountForTestingNotSet = static_cast<size_t>(-1);
 
 // static
 size_t NavigationControllerImpl::max_entry_count_for_testing_ =
     kMaxEntryCountForTestingNotSet;
 
@@ skipping 921 matching lines @@
         params.url, params.referrer, params.method, params.post_id);
     new_entry = GetLastCommittedEntry()->CloneAndReplace(
         frame_entry, true, rfh->frame_tree_node(),
         delegate_->GetFrameTree()->root());
 
     // We expect |frame_entry| to be owned by |new_entry|.  This should never
     // fail, because it's the main frame.
     CHECK(frame_entry->HasOneRef());
 
     update_virtual_url = new_entry->update_virtual_url_with_url();
-
-    MaybeDumpCopiedNonSameOriginEntry("New page navigation", params, is_in_page,
-                                      GetLastCommittedEntry());
   }
 
   // Only make a copy of the pending entry if it is appropriate for the new page
   // that was just loaded. Verify this by checking if the entry corresponds
   // to the given navigation handle. Additionally, coarsely check that:
   // 1. The SiteInstance hasn't been assigned to something else.
   // 2. The pending entry was intended as a new entry, rather than being a
   // history navigation that was interrupted by an unrelated,
   // renderer-initiated navigation.
   // TODO(csharrison): Investigate whether we can remove some of the coarser
@@ skipping 84 matching lines @@
 
   // TODO(creis): Classify location.replace as NEW_PAGE instead of EXISTING_PAGE
   // in https://crbug.com/596707.
 
   NavigationEntryImpl* entry;
   if (params.intended_as_new_entry) {
     // This was intended as a new entry but the pending entry was lost in the
     // meanwhile and no new page was created. We are stuck at the last committed
     // entry.
     entry = GetLastCommittedEntry();
-    MaybeDumpCopiedNonSameOriginEntry("Existing page navigation", params,
-                                      is_in_page, entry);
   } else if (params.nav_entry_id) {
     // This is a browser-initiated navigation (back/forward/reload).
     entry = GetEntryWithUniqueID(params.nav_entry_id);
 
     // Needed for the restore case, where the serialized NavigationEntry doesn't
     // have the SSL state. Note that for in-page navigation, there's no
     // SSLStatus in the NavigationHandle so don't overwrite the existing entry's
     // SSLStatus.
     if (!is_in_page)
       entry->GetSSL() = handle->ssl_status();
@@ skipping 912 matching lines @@
     }
   }
 }
 
 void NavigationControllerImpl::SetGetTimestampCallbackForTest(
     const base::Callback<base::Time()>& get_timestamp_callback) {
   get_timestamp_callback_ = get_timestamp_callback;
 }
 
 }  // namespace content